Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pandas version check, require Python ≥ 3.8 #110

Merged
merged 4 commits into from
Sep 22, 2024

Conversation

kddubey
Copy link
Contributor

@kddubey kddubey commented Apr 29, 2024

Hello,

This corrects the version check in #105. The current check will fail when we're (hopefully) retired and pandas v10 comes out:

print("10.0.0" < "2.1.0")
# True
# yikes!

from packaging.version import Version
print(Version("10.0.0") < Version("2.1.0"))
# False

Docs for packaging.version.Version

The PR adds a new required dependency from PyPA: packaging. It has no dependencies but requires Python ≥ 3.8. I'm not sure if this change is too breaking b/c the test workflow only tests Python ≥ 3.9, and bambi requires Python ≥ 3.10. And Python 3.7 reached EOL on 2023-06-27. Feel free to close the PR if this breaking change is too much breaking / you want to fix the version check a different way

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.63%. Comparing base (b00f53d) to head (fb320c3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #110   +/-   ##
=======================================
  Coverage   92.63%   92.63%           
=======================================
  Files          20       20           
  Lines        2227     2228    +1     
=======================================
+ Hits         2063     2064    +1     
  Misses        164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomicapretto
Copy link
Collaborator

@kddubey thanks for the contribution and sorry for taking so long to review and merge it.

@tomicapretto tomicapretto merged commit 1b91143 into bambinos:master Sep 22, 2024
4 checks passed
@kddubey kddubey deleted the fix-pandas-version-check branch September 22, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants