Fix pandas version check, require Python ≥ 3.8 #110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This corrects the version check in #105. The current check will fail when we're (hopefully) retired and
pandas
v10 comes out:Docs for
packaging.version.Version
The PR adds a new required dependency from PyPA:
packaging
. It has no dependencies but requires Python ≥ 3.8. I'm not sure if this change is too breaking b/c the test workflow only tests Python ≥ 3.9, andbambi
requires Python ≥ 3.10. And Python 3.7 reached EOL on 2023-06-27. Feel free to close the PR if this breaking change is too much breaking / you want to fix the version check a different way