Add compatibility with standard C11 #120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelafsilva5
requested review from
josecm,
sandro2pinto,
DavidMCerdeira and
danielRep
as code owners
josecm
reviewed
Jan 26, 2024
Makefile
Outdated
| @@ -235,7 +235,7 @@ $(build_dir)/%.d : $(src_dir)/%.[c,S] | |||
|
|
|||
| $(objs-y): | |||
| @echo "Compiling source $(patsubst $(cur_dir)/%, %, $<)" | |||
| @$(cc) $(CFLAGS) -c $< -o $@ | |||
| -@$(cc) $(CFLAGS) -c $< -o $@ | |||
There was a problem hiding this comment.
We should not be suppressing build errors.
There was a problem hiding this comment.
Should be fixed in the recent commit.
Initial commit for the process of adapting bao to the standard C11. Modified the makefile to compile according to C11 and reject the use of any extension. Signed-off-by: Miguel Silva <miguelafsilva5@gmail.com>
miguelafsilva5
force-pushed
the
wip/c11
branch
from
2f51a6c to
bb8025a
Compare
|
Closing this as it is already addressed in #122 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The usage of a C standard without any extensions is a required rule in MISRA compliance.
This PR will serve as a hub for most modifications regarding the standard C11 and additonal MISRA rules that can be verified by the compiler.
Ideally, each PR made to this WIP will represent a rule or a subset of MISRA rules that are verified with additional compiling flags.