fix(config): vm_dev_region struct field order, type casting, and macro usage #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopeixoto13
requested review from
josecm,
DavidMCerdeira,
sandro2pinto and
danielRep
as code owners
joaopeixoto13
force-pushed
the
fix/config
branch
from
faa4132 to
02de4a8
Compare
DavidMCerdeira
previously approved these changes
Sep 16, 2024
josecm
reviewed
Sep 17, 2024
|
@joaopeixoto13 please make sure you indicate this is in the example config in the commit message |
The two commit messages already include the header |
Signed-off-by: João Peixoto <joaopeixotooficial@gmail.com>
Signed-off-by: João Peixoto <joaopeixotooficial@gmail.com>
joaopeixoto13
force-pushed
the
fix/config
branch
from
02de4a8 to
46c686d
Compare
DavidMCerdeira
requested review from
josecm,
DavidMCerdeira and
miguelafsilva5
DavidMCerdeira
approved these changes
Sep 17, 2024
miguelafsilva5
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.