Ignore exit code of clang-format-diff #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps debug what is happening when a git command fails in a test.
Newer versions of git don't allow this by default. Specify the appropriate config option on the command line to allow it.
Starting with 18.x, clang-format-diff exits with a nonzero exit code if there was a diff to be applied. This breaks the apply-format script because it will exit without printing the diff. Instead, ignore the exit code and proceed to print the diff. Closes: barisione#33
|
Note, clang-format-diff 18.x has another regression: llvm/llvm-project#86776 This causes the |
gnomesysadmins
pushed a commit
to GNOME/gjs
that referenced
this pull request
Jul 28, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt to breaking change in clang-format-diff 18.x. The PR also includes a few unrelated cleanups.
Closes: #33