Upgradeable L2 Resolver #98
Open
+1,583
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🟡 Heimdall Review Status
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Slither found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
stevieraykatz
changed the title
stevieraykatz
commented
Nov 15, 2024
| return implementer; | ||
| } | ||
|
|
||
| address a = IAddrResolver(address(this)).addr(node); |
There was a problem hiding this comment.
NOTE: This is a deviation from ENS's inheritance-based approach and should be looked at closely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The L2 Resolver contract currently deployed is immutable. Though it currently inherits all of the most modern ENS resolver profiles, we know that we'll want to add/upgrade our resolver in the future as new features and ENSIPs come online.
This PR implements a functionally equivalent L2 Resolver but with some notable features:
initialize()method