Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiname management #1216

Merged
merged 30 commits into from
Nov 7, 2024
Merged

Multiname management #1216

merged 30 commits into from
Nov 7, 2024

Conversation

zencephalon
Copy link
Collaborator

@zencephalon zencephalon commented Nov 6, 2024

What changed? Why?

Manually.

Screenshot 2024-11-06 at 11 08 43 AM

Notes to reviewers

How has it been tested?

Manually.

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 5:41pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 5:41pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Nov 6, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

kirkas
kirkas previously approved these changes Nov 6, 2024
apps/web/src/components/Basenames/ManageNames/hooks.tsx Outdated Show resolved Hide resolved
@cb-heimdall cb-heimdall dismissed kirkas’s stale review November 6, 2024 20:03

Approved review 2419255383 from kirkas is now dismissed due to new commit. Re-request for approval.

@zencephalon zencephalon merged commit ce51c6e into master Nov 7, 2024
10 checks passed
@zencephalon zencephalon deleted the feat/multiname-management branch November 7, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants