-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(secrets): add Doppler adapter #1099
feat(secrets): add Doppler adapter #1099
Conversation
Thanks @mrbongiolo! It looks like there's no concept of an account for Doppler (or at least we the adapter doesn't need to know about it), so I think we should just make the account optional. That could be a new The kamal secrets fetch --adapter doppler --from my-project/prd SECRET1 SECRET2 SECRET3 or: kamal secrets fetch --adapter doppler my-project/prd/SECRET1 my-project/prd/SECRET2 my-project/prd/SECRET3 The second format would allow you to extract secrets from different projects or configs if really needed. |
Oh, could we also implement the |
Thanks for the review @djmb!! I'll fix the points that you brought up and update the PR later today. |
@djmb PR updated. Also added support for I will update the docs PR soon as well. With the current approach, the doppler adapter doesn't support fetching secrets from multiple |
Doppler organizes secrets in "projects" (like
my-awesome-project
) and "configs" (likeprod
,stg
, etc.), so the patternproject/config
is required when defining the--account
option.Doppler does not have a concept of folders, so using
--from
option orFOLDER/SECRET
pattern is not supported and will raise an error.Initially, I was thinking of using the
--from
option to define the Doppler "config", but this would require a much larger change in how secrets are "folderized", so not allowing to use that option and parsing--account=project/config
accordingly seemed like a better approach for now.Site documentation PR: basecamp/kamal-site#134