Updated secrets error message if secrets files do not exist #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidanharan
force-pushed
the
secrets-files-not-found-message
branch
from
7402e40 to
c320343
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you initialize a new project a
.kamal/secretsfile is created. If you create a new destination configconfig/deploy.other.ymland try to deploy you get the obscure error messageERROR (Kamal::ConfigurationError): Secret 'KAMAL_REGISTRY_PASSWORD' not found in. The error message should have beenSecret 'KAMAL_REGISTRY_PASSWORD' not found, no secret files providedbut there was a small bug with[]being consideredtrue.The original error message doesn't mention that you need to create
.kamal/secrets-commonor.kamal/secrets.other. This PR updates the error message so that you are made aware of the the secrets files that Kamal is looking for.