Allow for Custom Accessory Service Name #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/kamal/configuration/accessory.rb
Outdated
| @@ -8,7 +8,7 @@ def initialize(name, config:) | |||
| end | |||
|
|
|||
| def service_name | |||
| "#{config.service}-#{name}" | |||
| specifics['service'] || "#{config.service}-#{name}" | |||
There was a problem hiding this comment.
Please use double quotes for strings.
rience
force-pushed
the
custom-acc-service-name
branch
from
89e5bcc to
ca078c5
Compare
|
@rience can you please check locally, what test does not pass? |
rience
force-pushed
the
custom-acc-service-name
branch
from
ca078c5 to
b411356
Compare
igor-alexandrov
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my company we deploy several applications to single vm. They all share accessories - Postgres, Redis. Unfortunately at the moment - service name for accessory is created by concatenating deployment app name with name of accessory. So if I deploy
app1and thenapp2- I would end up with two Postgres instances -app1-postgresandapp2-postgres. Because of that we have separate YAML file - only for managing accessories.This PR adds
servicesetting to accessory - and that allows for custom service name. Of course previous behaviour stays - this is optional.EDIT: I believe it could also help with this discussion: #257