Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provenance option #972

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Conversation

kohkimakimoto
Copy link
Contributor

@kohkimakimoto kohkimakimoto commented Sep 25, 2024

Summary

This PR adds a provenance option in the builder config. You can use provenance: false to prevent the showing of unknown/unknown architecture on the container registry.

Description

I am using Kamal with GitHub Container Registry, and it works very well. However, when I push images to the container registry, I noticed an unknown/unknown architecture listed on the registry. See the screenshot below.

CleanShot 2024-09-25 at 19 04 38@2x

I believe this is an issue with the UI of the registry service, such as GitHub Container Registry. You can use provenance: false as a workaround to avoid the issue.

Once the PR is merged, you can use the following config to prevent pushing the unknown/unknown architecture.

builder:
  arch: amd64
  provenance: false

Related information

@@ -97,6 +97,10 @@ def build_ssh
argumentize "--ssh", ssh if ssh.present?
end

def builder_provenance
argumentize "--provenance", provenance unless provenance.nil?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
argumentize "--provenance", provenance unless provenance.nil?
argumentize "--provenance", provenance if provenance.present?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentional design, because if provenance is false, it should output the --provenance false option. It should only skip outputting --provenance … if provenance is nil.

@kohkimakimoto
Copy link
Contributor Author

See also #838
It is a related discussion.

@lado936
Copy link

lado936 commented Oct 16, 2024

Any new on this? i am testing kamal for side project and this feature would be really helpful as right now in Gitlab CI, you cant check any info about image

@djmb djmb merged commit 57d582e into basecamp:main Oct 23, 2024
6 of 7 checks passed
@kohkimakimoto kohkimakimoto deleted the dev-provenance-flag branch December 12, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants