-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review field for full-text search in default schema #711
base: develop
Are you sure you want to change the base?
Review field for full-text search in default schema #711
Conversation
In 2013, [usage] of `text` field was deleted. In 2014, `text` stopped to be [default] field and [comment] on aim of `text` field was deleted. Hence only the definition of field `text` was left. [usage]: 5ed36bb#diff-a5640d83f118f6b45ab6c388a89507dcL258 [default]: 7e106dc#diff-a54ecf58f2bd4054b393a8c7b4cbc782L540 [comment]: 5d813cc#diff-a5640d83f118f6b45ab6c388a89507dcL26 This change reviews field `text` in the following way: * Comment field definition, alongside commented sample intended usage; * Rename field to `_text_` as apparent upstream [preference]. [preference]: apache/lucene-solr@a4be57c Note: * Is is ok to use wildcard as source i.e. [`<copyField source="*" ...`](https://github.com/apache/lucene-solr/blob/releases/lucene-solr/6.3.0/solr/server/solr/configsets/data_driven_schema_configs/conf/managed-schema#L128).
Replaces #710 (RIAK-1634) . |
There seems to be an issue with build step **make_test** ! ☁️✅ MERGE
✅ MAKE_CLEAN
⛔ MAKE_TEST
✅ MAKE_XREF
✅ MAKE_DIALYZER
⬜ 0 of 2 Code reviews from organization basho |
Make test failure appears unrelated to this PR:
|
There seems to be an issue with build step **make_test** ! ☁️✅ MERGE
✅ MAKE_CLEAN
⛔ MAKE_TEST
✅ MAKE_XREF
✅ MAKE_DIALYZER
⬜ 0 of 2 Code reviews from organization basho |
Looks good! 👍✅ MERGE
✅ MAKE_CLEAN
✅ MAKE_TEST
✅ MAKE_XREF
✅ MAKE_DIALYZER
⬜ 0 of 2 Code reviews from organization basho |
Tests pass. This looks still applicable and ready to be merged. |
Looks good! 👍✅ MERGE
✅ MAKE_CLEAN
✅ MAKE_TEST
✅ MAKE_XREF
✅ MAKE_DIALYZER
⬜ 0 of 2 Code reviews from organization basho |
I tried full-text search and I reviewed the default schema on this topic - hence the PR. An alternative to this PR would be the complete deletion of field named
text
as it is unused.Please refer to commit message for details.