Merge remote-tracking branch 'origin/master' into issue_882_reproducer

.gitignore

@@ -1,3 +1,5 @@
 bin/
 *.log
 target/
+.polyglot.*
+pom.tycho

.mvn/extensions.xml

@@ -0,0 +1,9 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<extensions>
+	<extension>
+		<groupId>org.eclipse.tycho</groupId>
+		<artifactId>tycho-build</artifactId>
+		<version>4.0.4</version>
+	</extension>
+</extensions>

Jenkinsfile

@@ -92,7 +92,7 @@ pipeline {
 						git config --global user.email 'eclipse-releng-bot@eclipse.org'
 						git config --global user.name 'Eclipse Releng Bot'
 						
-						ant -f eclipse.platform.swt/bundles/org.eclipse.swt/buildSWT.xml check_sources_and_update_sha1_file -DTAG=HEAD
+						ant -f eclipse.platform.swt/bundles/org.eclipse.swt/buildSWT.xml check_preprocessing
 						ant -f eclipse.platform.swt/bundles/org.eclipse.swt/buildSWT.xml new_build_with_create_file -DTAG=HEAD
 					'''
 				}

bundles/org.eclipse.swt.tools.base/META-INF/MANIFEST.MF

@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-Name: %pluginName
 Bundle-Vendor: %providerName
 Bundle-SymbolicName: org.eclipse.swt.tools.base;singleton:=true
-Bundle-Version: 3.107.400.qualifier
+Bundle-Version: 3.107.500.qualifier
 Bundle-ManifestVersion: 2
 Bundle-ActivationPolicy: lazy
 Bundle-Localization: plugin

bundles/org.eclipse.swt.tools.base/build.properties

@@ -17,3 +17,6 @@ bin.includes = about.html,\
                META-INF/,\
                .
 src.includes = about.html
+
+pom.model.groupId = org.eclipse.swt
+tycho.pomless.parent = ../../local-build/local-build-parent

bundles/org.eclipse.swt.tools.spies/META-INF/MANIFEST.MF

@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-Name: %pluginName
 Bundle-Vendor: %providerName
 Bundle-SymbolicName: org.eclipse.swt.tools.spies;singleton:=true
-Bundle-Version: 3.109.100.qualifier
+Bundle-Version: 3.109.200.qualifier
 Bundle-ManifestVersion: 2
 Export-Package: org.eclipse.swt.tools.internal,
  org.eclipse.swt.tools.views
@@ -16,4 +16,4 @@ Require-Bundle: org.eclipse.core.runtime;bundle-version="3.29.0",
  org.eclipse.ui;bundle-version="3.113.0",
  org.eclipse.e4.ui.di;bundle-version="1.2.600"
 Automatic-Module-Name: org.eclipse.swt.tools.spies
-Import-Package: javax.annotation;version="1.2.0"
+Import-Package: jakarta.annotation;version="[2.1.0,3.0.0)"

bundles/org.eclipse.swt.tools.spies/build.properties

@@ -21,3 +21,6 @@ bin.includes = about.html,\
 output.. = bin/
 source.. = src/
 src.includes = about.html
+
+pom.model.groupId = org.eclipse.swt
+tycho.pomless.parent = ../../local-build/local-build-parent

bundles/org.eclipse.swt.tools.spies/src/org/eclipse/swt/tools/internal/Sleak.java

@@ -31,7 +31,6 @@
  *
  * Modify the main method below to launch your application.
  * Run Sleak.
- *
  */
 public class Sleak {
 	List list;

bundles/org.eclipse.swt.tools.spies/src/org/eclipse/swt/tools/internal/SpiesConstants.java

@@ -13,7 +13,6 @@
 
 /**
  * Interface containing constants for the Spies plug-in.
- * 
  */
 
 public interface SpiesConstants {

bundles/org.eclipse.swt.tools.spies/src/org/eclipse/swt/tools/views/SleakView.java

@@ -14,12 +14,12 @@
  *******************************************************************************/
 package org.eclipse.swt.tools.views;
 
-import javax.annotation.*;
-
 import org.eclipse.e4.ui.di.*;
 import org.eclipse.swt.tools.internal.*;
 import org.eclipse.swt.widgets.*;
 
+import jakarta.annotation.*;
+
 /**
  * Sleak view to trace native handler allocation
  */

bundles/org.eclipse.swt.tools/Icon Exe/org/eclipse/swt/tools/internal/IconExe.java

@@ -1101,7 +1101,6 @@ static class ImageLoader {
 	 * the background pixel for the logical screen (this 
 	 * corresponds to the GIF89a Background Color Index value).
 	 * The default is -1 which means 'unspecified background'
-	 * 
 	 */
 	public int backgroundPixel;
 

bundles/org.eclipse.swt.tools/Oomph/platformSwt.setup

@@ -38,6 +38,12 @@
         <value>remoteURI</value>
       </detail>
     </annotation>
+    <configSections
+        name="branch">
+      <properties
+          key="autoSetupRebase"
+          value="always"/>
+    </configSections>
     <description>Platform SWT</description>
   </setupTask>
   <setupTask
@@ -75,6 +81,12 @@
         <value>remoteURI</value>
       </detail>
     </annotation>
+    <configSections
+        name="branch">
+      <properties
+          key="autoSetupRebase"
+          value="always"/>
+    </configSections>
     <description>Platform SWT</description>
   </setupTask>
   <setupTask
@@ -252,6 +264,12 @@
           <value>remoteURI</value>
         </detail>
       </annotation>
+      <configSections
+          name="branch">
+        <properties
+            key="autoSetupRebase"
+            value="always"/>
+      </configSections>
       <description>SWT Website</description>
     </setupTask>
     <setupTask

bundles/org.eclipse.swt.tools/build.properties

@@ -26,3 +26,6 @@ source.. = src/,\
            JavadocBasher/
 src.includes = about.html
 bin.excludes = META-INF/p2.inf
+
+pom.model.groupId = org.eclipse.swt
+tycho.pomless.parent = ../../local-build/local-build-parent

bundles/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/CBanner.java

@@ -100,7 +100,6 @@ public class CBanner extends Composite {
  * @exception SWTException <ul>
  *    <li>ERROR_THREAD_INVALID_ACCESS - if not called from the thread that created the parent</li>
  * </ul>
- *
  */
 public CBanner(Composite parent, int style) {
 	super(parent, checkStyle(style));

bundles/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/CTabFolder.java

@@ -872,7 +872,6 @@ ToolBar getChevron() {
  *    <li>ERROR_WIDGET_DISPOSED - if the receiver has been disposed</li>
  *    <li>ERROR_THREAD_INVALID_ACCESS - if not called from the thread that created the receiver</li>
  * </ul>
- *
  */
 /*public*/ boolean getChevronVisible() {
 	checkWidget();
@@ -4176,7 +4175,6 @@ int getWrappedHeight (Point size) {
  *    <li>ERROR_THREAD_INVALID_ACCESS when called from the wrong thread</li>
  *    <li>ERROR_WIDGET_DISPOSED when the widget has been disposed</li>
  * </ul>
- *
  */
 /*public*/ void setChevronVisible(boolean visible) {
 	checkWidget();

bundles/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/CTabFolderRenderer.java

@@ -755,9 +755,6 @@ void drawBackground(GC gc, int[] shape, int x, int y, int width, int height, Col
 
 	/*
 	 * Draw the border of the tab
-	 *
-	 * @param gc
-	 * @param shape
 	 */
 	void drawBorder(GC gc, int[] shape) {
 
@@ -1045,8 +1042,6 @@ void drawHighlight(GC gc, Rectangle bounds, int state, int rightEdge) {
 
 	/*
 	 * Draw the unselected border for the receiver on the left.
-	 *
-	 * @param gc
 	 */
 	void drawLeftUnselectedBorder(GC gc, Rectangle bounds, int state) {
 		int x = bounds.x;
@@ -1184,8 +1179,6 @@ void drawMinimize(GC gc, Rectangle minRect, int minImageState) {
 
 	/*
 	 * Draw the unselected border for the receiver on the right.
-	 *
-	 * @param gc
 	 */
 	void drawRightUnselectedBorder(GC gc, Rectangle bounds, int state) {
 		int x = bounds.x;

bundles/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/ControlEditor.java

@@ -118,7 +118,6 @@ public class ControlEditor {
 * Creates a ControlEditor for the specified Composite.
 *
 * @param parent the Composite above which this editor will be displayed
-*
 */
 public ControlEditor (Composite parent) {
 	this.parent = parent;

bundles/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/StyledText.java

@@ -10235,10 +10235,7 @@ void setStyleRanges(int start, int length, int[] ranges, StyleRange[] styles, bo
 /**
  *
  * @param referenceRanges former ranges, sorted by order and without overlapping, typically returned {@link #getRanges(int, int)}
- * @param referenceStyles
  * @param newRanges former ranges, sorted by order and without overlapping
- * @param newStyles
- * @return
  */
 private SortedSet<Integer> computeModifiedLines(int[] referenceRanges, StyleRange[] referenceStyles, int[] newRanges, StyleRange[] newStyles) {
 	if (referenceStyles == null) {
@@ -10329,9 +10326,6 @@ private boolean isInRange(int[] ranges, int styleIndex, int offset) {
 
 /**
  * The offset on which the range ends (excluded)
- * @param ranges
- * @param styleIndex
- * @return
  */
 private int endRangeOffset(int[] ranges, int styleIndex) {
 	if (styleIndex < 0 || 2 * styleIndex > ranges.length) {

bundles/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/StyledTextEvent.java

@@ -16,9 +16,6 @@
 import org.eclipse.swt.graphics.*;
 import org.eclipse.swt.widgets.*;
 
-/**
- *
- */
 class StyledTextEvent extends Event {
 	// used by LineStyleEvent
 	int[] ranges;

bundles/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/StyledTextListener.java

@@ -18,8 +18,6 @@
 import org.eclipse.swt.widgets.*;
 
 class StyledTextListener extends TypedListener {
-/**
- */
 StyledTextListener(SWTEventListener listener) {
 	super(listener);
 }

bundles/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/TableCursor.java

@@ -195,7 +195,6 @@ public void getName(AccessibleEvent e) {
  * @see SelectionListener
  * @see SelectionEvent
  * @see #removeSelectionListener(SelectionListener)
- *
  */
 public void addSelectionListener(SelectionListener listener) {
 	checkWidget();
@@ -626,7 +625,6 @@ public void setForeground (Color color) {
  *    <li>ERROR_WIDGET_DISPOSED - if the receiver has been disposed</li>
  *    <li>ERROR_THREAD_INVALID_ACCESS - if not called from the thread that created the receiver</li>
  * </ul>
- *
  */
 public void setSelection(int row, int column) {
 	checkWidget();
@@ -649,7 +647,6 @@ public void setSelection(int row, int column) {
  *    <li>ERROR_WIDGET_DISPOSED - if the receiver has been disposed</li>
  *    <li>ERROR_THREAD_INVALID_ACCESS - if not called from the thread that created the receiver</li>
  * </ul>
- *
  */
 public void setSelection(TableItem row, int column) {
 	checkWidget();

bundles/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/TableEditor.java

@@ -87,7 +87,6 @@ public class TableEditor extends ControlEditor {
 * Creates a TableEditor for the specified Table.
 *
 * @param table the Table Control above which this editor will be displayed
-*
 */
 public TableEditor (Table table) {
 	super(table);

bundles/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/TreeEditor.java

@@ -87,7 +87,6 @@ public class TreeEditor extends ControlEditor {
 * Creates a TreeEditor for the specified Tree.
 *
 * @param tree the Tree Control above which this editor will be displayed
-*
 */
 public TreeEditor (Tree tree) {
 	super(tree);

bundles/org.eclipse.swt/Eclipse SWT Drag and Drop/common/org/eclipse/swt/dnd/DragSourceListener.java

@@ -25,7 +25,6 @@
  * <p>After the drop has completed successfully or has been aborted, the application which defines the
  * <code>DragSource</code> is required to take the appropriate cleanup action.  In the case of a successful
  * <b>move</b> operation, the application must remove the data that was transferred.</p>
- *
  */
 public interface DragSourceListener extends SWTEventListener {
 

bundles/org.eclipse.swt/Eclipse SWT Drag and Drop/common/org/eclipse/swt/dnd/DropTargetListener.java

@@ -34,7 +34,6 @@
  * operation that is performed but the data type is fixed.</p>
  *
  * @see DropTargetEvent
- *
  */
 public interface DropTargetListener extends SWTEventListener {