Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(basti): EBS volume encrypted #95

Conversation

GustavoAdrianGimenez
Copy link
Contributor

Proposed Changes

To enhance security, it's important to attach encrypted EBS volumes for EC2 instances.

Related Issues/PRs

#94

Checklist

  • I cleaned up my code.
  • All the tests and checks passed (npm run test).
  • I have added necessary documentation and/or updated existing documentation.
  • I have added or modified tests to cover the changes.

Copy link
Collaborator

@BohdanPetryshyn BohdanPetryshyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me! Thank you for your contribution @GustavoAdrianGimenez ❤️

I will be able to test and release the changes on weekends.

README.md Outdated Show resolved Hide resolved
packages/basti/README.md Outdated Show resolved Hide resolved
@BohdanPetryshyn
Copy link
Collaborator

Just tested the changes both in Basti CLI and Basti CDK. Works like a charm!

@BohdanPetryshyn BohdanPetryshyn merged commit 393e141 into basti-app:main Mar 30, 2024
3 checks passed
@BohdanPetryshyn BohdanPetryshyn changed the title Feature/ebs volume encrypted feat(basti): EBS volume encrypted Mar 30, 2024
@BohdanPetryshyn
Copy link
Collaborator

Basti CLI has just been released. Basti CDK will be released tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants