forked from buildfarm/buildfarm
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade bazel-ios-fork to v2.10.2 #6
Draft
chenj-hub
wants to merge
317
commits into
bazel-ios-fork
Choose a base branch
from
jackies/upgrade-bazel-buildfarm-to-v2.10.2
base: bazel-ios-fork
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Upgrade bazel-ios-fork to v2.10.2 #6
chenj-hub
wants to merge
317
commits into
bazel-ios-fork
from
jackies/upgrade-bazel-buildfarm-to-v2.10.2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A shard server is impractical without operation subscription, partition subscription confirmation between servers and workers. The failsafe execution is configuration that is likely not desired on workers. This change removes the failsafe behavior from workers via backplane config, and relegates the setting of failsafe boolean to server config. If the option is restored for workers, it can be added to worker configs so that configs may continue to be shared between workers and servers and retain independent addressability.
Internally driven metrics and scaling controls have low, if any, usage rates. Prometheus has largely succeeded independent publication of metrics, and externally driven scaling is the norm. These modules have been incomplete between cloud providers, and for the functional side of AWS, bind us to springboot. Removing them for the sake of reduced dependencies and complexity.
Remove this unused OperationQueue feature which provides no invocations on any use.
This reverts commit f651cdb.
Continue the loop while we have *not* matched successfully and avoid a confusing inversion in getMatched()
Distinguish the valid/unique/propagating methods of entry listening.
The only signal to a waiting match that will halt its current listen loop for a valid unique operation is an interrupt.
Distinguish target param with GRPC type storage from FILESYSTEM definition
Reinstate prior usage of LoggingMain for safe shutdown, with added release mechanism for interrupted processes. All invoked shutdowns are graceful, with vastly improved shutdown speed for empty workers waiting for pipeline stages.
Tiny code cleanup
Will include operation root and inform directory cache effectiveness.
Selecting realInputDirectories by regex permits flexible patterns that can yield drastic improvements in directory reuse for specialized deployments. runfiles in particular are hazardous expansions of nearly-execroot in the case of bazel. Care must be taken to match directories exclusively. The entire input tree is traversed for matches against expanded paths under the root, to allow for nested selection. Each match thus costs the number of input directories. Counterintuitively, OutputFiles are augmented to avoid the recursive check for OutputDirectories which only applies to actual reported results, resulting in a path match when creating the exec root. Regex style is java.util.Pattern, and must match the full input directory.
This will include the path to the missed directory and the operation which required it.
Prevent adding duplicate realInputDirectories matches
Ensure that the last leg of the execution presents a directory, rather than the parent, per OutputDirectory's stamping.
Support a `--redis_uri` command line option for start-up.
also fixed some spelling typos.
Bumping 4.2 -> 5.3
Bump fro 0.0.6 -> 0.0.9
Since we declare a buildifier target in //BUILD, we can't make this a dev dependency.
When a duplicate output stream is detected, we must signal the writeWinner (because the write exists) and onInsert (because it was inserted) for an output stream creation. If we're racing, we should be eventually convergent, but this absolutely fixes a hang which occurs on this sentinel stream's return into getOutput, where the future might never be triggered otherwise.
Move future completion into the only scope it was actually missing from - getOutput for Write, rather than inducing all `put` calls into posts to backplane via onPut with duplicates.
chenj-hub
force-pushed
the
jackies/upgrade-bazel-buildfarm-to-v2.10.2
branch
2 times, most recently
from
August 13, 2024 14:30
eef5cb9
to
d7d6604
Compare
Resolved git conflict between v.2.10.2 and current bazel-ios-fork from running:
|
This reverts commit 99eca33.
…upgrade-bazel-buildfarm-to-v2.10.2
chenj-hub
force-pushed
the
jackies/upgrade-bazel-buildfarm-to-v2.10.2
branch
from
August 13, 2024 20:42
de650e7
to
64b71b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging v2.10.2 of bazel-buildfarm to our bazel-ios-fork