Add a native image of turbine to the prebuilt Java tools #19361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @sgammon Based on the docs of rules_graalvm, I assume I will have to wait for version 0.10.0 to get Windows support? |
fmeum
force-pushed
the
native-turbine
branch
2 times, most recently
from
f3d0bf3
to
8f822ee
Compare
fmeum
force-pushed
the
native-turbine
branch
2 times, most recently
from
f5dcfce
to
c9f9764
Compare
|
@fmeum windows support is shipped on there are now integration tests for Bazel 4-7, and each type of GVM variant, etc. Windows runs most of these, it just skips the Sticking with the latest GVM version and rule version should provide good Windows support against MSVC, modulo any bugs you might encounter in the newer hermeticity advice. Keep in mind that |
|
ah, it looks like it's complaining about the toolchain:
|
fmeum
force-pushed
the
native-turbine
branch
14 times, most recently
from
e82360b
to
de64a2e
Compare
|
With sgammon/rules_graalvm#70, sgammon/rules_graalvm#71, sgammon/rules_graalvm#72, and sgammon/rules_graalvm#73 I can get the |
fmeum
force-pushed
the
native-turbine
branch
from
8744162
to
e414cf7
Compare
Closed
fmeum
force-pushed
the
native-turbine
branch
from
e414cf7
to
aa2c53c
Compare
|
Hi @fmeum, Could you please resolve the conflicts? |
fmeum
force-pushed
the
native-turbine
branch
2 times, most recently
from
4630ff5
to
fb71ab0
Compare
|
@sgowroji Done |
|
@sgowroji Also done! |
sgowroji
added
awaiting-review
fmeum
force-pushed
the
native-turbine
branch
from
e5d4bf2
to
05f966a
Compare
A simple local experiment shows that the time for all Java header compilation actions required for `//src:bazel-dev` decreases by a factor of 4.5 when using a native image of turbine instead of jar. The time taken for an incremental build of `//src/main/java/com/google/devtools/build/lib/bazel:BazelServer` after adding a public method to `Label` decreases by a factor of 2 with `--experimental_java_classpath=bazel`. As a first step towards using the native image in Java toolchains, ship it as part of the prebuilt Java tools by using rules_graalvm.
fmeum
force-pushed
the
native-turbine
branch
from
05f966a
to
212e044
Compare
|
@sgowroji I fixed the new merge conflict. |
github-actions
bot
removed
the
awaiting-PR-merge
|
I'm terribly sorry that I thought this was a cherry-pick and merged this directly. I had to force push to master to fix the history and this PR should be merged by importing to google first, which is work in process. |
meteorcloudy
added
the
awaiting-PR-merge
|
I resolved the conflict in the lockfile. @sgowroji |
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 15, 2023
A simple local experiment shows that the time for all Java header compilation actions required for `//src:bazel-dev` decreases by a factor of 4.5 when using a native image of turbine instead of jar. The time taken for an incremental build of `//src/main/java/com/google/devtools/build/lib/bazel:BazelServer` after adding a public method to `Label` decreases by a factor of 2 with `--experimental_java_classpath=bazel`. As a first step towards using the native image in Java toolchains, ship it as part of the prebuilt Java tools by using rules_graalvm. Closes #19361. PiperOrigin-RevId: 582531539 Change-Id: If71d8ec86fecbc1363a748d197f88962bd489fb4
|
@keertk Could I ask you to create a new java_tools release now that this has been merged? I could then use it in a rules_java PR. |
sgowroji
removed
the
awaiting-PR-merge
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 21, 2024
) A simple local experiment shows that the time for all Java header compilation actions required for `//src:bazel-dev` decreases by a factor of 4.5 when using a native image of turbine instead of jar. The time taken for an incremental build of `//src/main/java/com/google/devtools/build/lib/bazel:BazelServer` after adding a public method to `Label` decreases by a factor of 2 with `--experimental_java_classpath=bazel`. As a first step towards using the native image in Java toolchains, ship it as part of the prebuilt Java tools by using rules_graalvm. Closes #19361. Commit 5f79684 PiperOrigin-RevId: 582531539 Change-Id: If71d8ec86fecbc1363a748d197f88962bd489fb4 --------- Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im> Co-authored-by: Xùdōng Yáng <wyverald@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple local experiment shows that the time for all Java header compilation actions required for
//src:bazel-devdecreases by a factor of 4.5 when using a native image of turbine instead of jar. The time taken for an incremental build of//src/main/java/com/google/devtools/build/lib/bazel:BazelServerafter adding a public method toLabeldecreases by a factor of 2 with--experimental_java_classpath=bazel.As a first step towards using the native image in Java toolchains, ship it as part of the prebuilt Java tools by using rules_graalvm.