Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully define the Timestamp and TimeRange in the spec #96

Merged
merged 4 commits into from
Jan 2, 2025

Conversation

philipnbbc
Copy link
Contributor

Details

This PR adds details on the representation of the Timestamp and TimeRange types in the TAMS API in the application note describing Timestamps in TAMS.

Pivotal Story (if relevant)

Story URL: https://www.pivotaltracker.com/story/show/188562895

Related PRs

Where appropriate. Indicate order to be merged.

Submitter PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • API version has been incremented if necessary
  • ADR status has been updated, and ADR implementation has been recorded
  • Documentation updated (README, etc.)
  • PR added to Pivotal story (if relevant)
  • Follow-up stories added to Pivotal

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on PRs

The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.

@philipnbbc philipnbbc requested a review from a team as a code owner November 21, 2024 12:26
Copy link
Member

@samdbmg samdbmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one nit inline

docs/appnotes/0008-timestamps-in-TAMS.md Outdated Show resolved Hide resolved
philipnbbc and others added 2 commits January 2, 2025 10:24
Co-authored-by: Sam Mesterton-Gibbons <sam.mesterton-gibbons@bbc.co.uk>
@philipnbbc philipnbbc merged commit ff4010a into main Jan 2, 2025
5 checks passed
@philipnbbc philipnbbc deleted the philipn-timestamp-def branch January 2, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants