Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NRPTI-1115] DEV FEATURE** Create Dockerfiles and docker-compose #1118

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

LocalNewsTV
Copy link
Contributor

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [NRPTI-###]
  • Documentation is updated to reflect change

Description

This PR includes the following proposed change(s):

  • Creation of a Dockerfile, docker-compose.yaml, and create-db.js seed file.
  • The Dockerization will allow creation of a Mongodb database and its respective collections set by default, reducing the onboarding time of a developer in manually getting the docker image, and setting up their database for development.

Benefits

  1. The Database can be readily setup much faster than the current manual process
    • The developer still needs to seed their own data
  2. No need to worry about correctly installing dependencies in the API when doing development work in the front end.
  3. Docker images are grouped together appropriately

image

Note

  • The commented out section in the docker-compose is in hopes of the API later getting a health endpoint (to maintain containers)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@LocalNewsTV LocalNewsTV merged commit dc38bbf into master Oct 4, 2023
5 checks passed
@LocalNewsTV LocalNewsTV deleted the nrpti-1115-dockerfiles branch October 4, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants