[NRPTI-1045] TESTS** Fix broken tests in API #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalNewsTV
requested review from
davidclaveau,
sanjaytkbabu and
pinkyandthekane
LocalNewsTV
changed the title
sanjaytkbabu
approved these changes
Oct 12, 2023
| @@ -152,7 +154,7 @@ describe('Map-Info Controller Testing', () => { | |||
|
|
|||
| request(app) | |||
| .delete(endpoint) | |||
| .query(qs.stringify({ mapInfoId: testObjectId.toString() })) | |||
There was a problem hiding this comment.
I see this is removed in this test, but in other tests it is kept in. Is there a reason for the removal?
There was a problem hiding this comment.
@pinkyandthekane
.query() already converts object entries into query strings like qs.stringify is doing. It should be fine to remove them across the board, but was out of scope for this bit of work.
davidclaveau
approved these changes
Oct 12, 2023
LocalNewsTV
force-pushed
the
1045-api-tests
branch
from
4b3c332 to
11111bb
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Standards
HOTFIX,FEATURE,etc][NRPTI-###]Description
This PR includes the following proposed change(s):
npm audit fixto immediately update non-breaking changes to the existing packages in/apinodemonto dev-dependencies so there's hot reloadingnpm run test-macto run API tests on apple silicone