-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TASK][NRPTI-1223] add two tests for work around act name changes #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…late test for acts.service
…g shown in component
3 tasks
fergmac
reviewed
May 16, 2024
...src/app/legislation/legislation-list-detail-public/legislation-list-detail.component.spec.ts
Show resolved
Hide resolved
fergmac
previously approved these changes
May 16, 2024
Quality Gate passedIssues Measures |
fergmac
approved these changes
May 28, 2024
deployed to prod |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ticket was created as a learning opportunity around testing in NRPTI. A test case has been created in both the frontend and backend. As well, one of the tests brought to light an uncaught bug in the error handling for a method (parseTitleFromXML). that bug has been corrected as part of this work.
Pull Request Standards
HOTFIX
,FEATURE
,etc
][NRPTI-###]
Description
This PR includes the following proposed change(s):