Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX][NRPTI-1226] added missing parameter to transformRecord calls in BCOGC integration utils tests #1227

Merged
merged 1 commit into from
May 22, 2024
Merged

[FIX][NRPTI-1226] added missing parameter to transformRecord calls in BCOGC integration utils tests #1227

merged 1 commit into from
May 22, 2024

Conversation

acatchpole
Copy link
Contributor

@acatchpole acatchpole commented May 22, 2024 •
edited
Loading

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [NRPTI-###]
  • Documentation is updated to reflect change

Description

This PR includes the following proposed change(s):

  • Added a missing parameter to transformRecord() calls in BCOGC integration utility tests
  • tests now pass
  • Also improved handling in BCOGC datasource.js. If a call to get the actName fails, the actCode will now be passed in. This is perfectly acceptable behaviour as many records are already being created with just the actCode instead of the associated actName.

@acatchpole acatchpole linked an issue May 22, 2024 that may be closed by this pull request
Fix BCOGC Integration Utility Tests #1226
Closed
2 tasks
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@acatchpole acatchpole marked this pull request as ready for review May 22, 2024 19:09
@acatchpole acatchpole requested review from fergmac and LocalNewsTV May 22, 2024 19:09
@acatchpole acatchpole merged commit bf1ed9d into master May 22, 2024
4 checks passed
@acatchpole acatchpole deleted the 1226-fix-bcogc-integration-utility-tests branch May 22, 2024 20:20
acatchpole added a commit that referenced this pull request May 22, 2024
@acatchpole
added missing parameter to transformRecord calls in BCOGC integration…
76cfea1 
… utility tests (#1227)
@acatchpole
Copy link
Contributor Author

deployed to prod

@acatchpole acatchpole self-assigned this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fergmac fergmac fergmac approved these changes

@LocalNewsTV LocalNewsTV Awaiting requested review from LocalNewsTV

Assignees

@acatchpole acatchpole

Labels
Backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix BCOGC Integration Utility Tests
2 participants
@acatchpole @fergmac