Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPDATE][NRPTI-1149] Update dependencies to address critical vulnerabilities #1229

Conversation

acatchpole
Copy link
Contributor

@acatchpole acatchpole commented May 28, 2024

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [NRPTI-###]
  • Documentation is updated to reflect change

Description

This PR includes the following proposed change(s):
There were 17 critical vulnerabilities identified by npm audit. 14 of those have been addressed by the changes listed below.

  • Updated babel translator packages (dependency of jest)
  • Updated express version
  • Running npm audit fix applied non-breaking updates to several other packages

Not Done:

Update mongoose to >=5.13.20

  • Despite showing no breaking changes, updating to >=5.13.4 causes 2 test suites (nris datasource tests) to not run. They fail with the error require-at: not a directory: <my-project-dir>/api. The actual functionality that these tests describe appear to all work as intended on this version, but I was unable to diagnose what was causing the tests to fail.
  • This thread shows testers of the reported vulnerability unable to reproduce its affects. Given the time already invested in trying to resolve, and the evidence that the reported vulnerability is not actually 'critical', I am leaving this update undone.
  • Details of reported vulnerability -> GHSA-9m93-w8w6-76hh

Update BSON to >=1.1.4

  • BSON is a sub-dependancy of db-migrate-mongodb :| : │ db-migrate-mongodb > mongodb > mongodb-core > bson
  • That package has not been updated in 6 years
  • Details of reported vulnerability -> GHSA-v8w9-2789-6hhr

@acatchpole acatchpole linked an issue May 28, 2024 that may be closed by this pull request
3 tasks
Copy link

sonarcloud bot commented May 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@acatchpole acatchpole marked this pull request as ready for review May 28, 2024 00:07
@acatchpole acatchpole requested review from fergmac and LocalNewsTV May 28, 2024 00:08
@acatchpole acatchpole merged commit 1ec544c into master May 28, 2024
4 checks passed
@acatchpole acatchpole deleted the 1149-update-packages-with-critical-vulnerabilities-for-nrpti-api branch May 28, 2024 15:58
@acatchpole
Copy link
Contributor Author

deployed to prod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update packages deemed Critical for NRPTI API
2 participants