[BUG][NRPTI-1231] Fix bug where manually added records are not appearing in the nrced csv export #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acatchpole
reviewed
Jun 12, 2024
| @@ -25,10 +25,6 @@ export class RecordsListResolver implements Resolve<Observable<object>> { | |||
| schemaList = params.activityType.split(','); | |||
| } | |||
|
|
|||
| if (params.act) { | |||
| params.act = RecordUtils.appendActCodesToActNames(params.act, this.factoryService); | |||
There was a problem hiding this comment.
appendActCodesToActNames was a function written just for this. it is used nowhere else and could be removed as well to avoid bloating the code base.
acatchpole
approved these changes
Jun 12, 2024
sggerard
force-pushed
the
1231-bug-when-manually-adding-a-record-to-nrpti-the-record-is-not-appearing-in-the-nrced-csv-export
branch
from
70b54da to
9c1c1da
Compare
Signed-off-by: sggerard <sggerard1997@gmail.com>
Signed-off-by: sggerard <sggerard1997@gmail.com>
sggerard
force-pushed
the
1231-bug-when-manually-adding-a-record-to-nrpti-the-record-is-not-appearing-in-the-nrced-csv-export
branch
from
9c1c1da to
3fa0342
Compare
|
sggerard
deleted the
1231-bug-when-manually-adding-a-record-to-nrpti-the-record-is-not-appearing-in-the-nrced-csv-export
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following proposed change(s):