Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host uxa #408

Merged
merged 9 commits into from
Dec 19, 2024
Merged

Host uxa #408

merged 9 commits into from
Dec 19, 2024

Conversation

deetz99
Copy link
Collaborator

@deetz99 deetz99 commented Dec 18, 2024

Issue:

Description of changes:

  • several fixes according to figma uxa file
  • done everything except for items with question marks, number of rooms scrolling stuff and making residential postal code not required
  • update strata dashboard column date format and column width to match same columns in hosts

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

radio group gap 16px

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove extra border at bottom of widget

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

min/max attrs for number inputs

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-strata-hotel-dev--pr-408-gggmew06.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-hosts-dev--pr-408-w9gl20mc.web.app

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add missing location description v-model

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add missing location description v-model

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-strata-hotel-dev--pr-408-gggmew06.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-hosts-dev--pr-408-w9gl20mc.web.app

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add dividers to requirements list

Copy link
Collaborator

@dimak1 dimak1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@deetz99 deetz99 merged commit 4c1da0d into bcgov:main Dec 19, 2024
31 of 33 checks passed
@deetz99 deetz99 deleted the host-uxa branch December 19, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants