Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All - ui: Linting #430

Merged
merged 5 commits into from
Jan 3, 2025
Merged

All - ui: Linting #430

merged 5 commits into from
Jan 3, 2025

Conversation

deetz99
Copy link
Collaborator

@deetz99 deetz99 commented Jan 3, 2025

Issue:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License

@deetz99 deetz99 requested a review from thorwolpert January 3, 2025 21:28
Copy link

sonarqubecloud bot commented Jan 3, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
12.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-examiner-dev--pr-430-z1azjr03.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-platform-dev--pr-430-z5uqpi9l.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-hosts-dev--pr-430-vsypjkfg.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-strata-hotel-dev--pr-430-0cmbgb7f.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-examiner-dev--pr-430-z1azjr03.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-platform-dev--pr-430-z5uqpi9l.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-strata-hotel-dev--pr-430-0cmbgb7f.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-hosts-dev--pr-430-vsypjkfg.web.app

Copy link
Collaborator

@thorwolpert thorwolpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add dangling , to ESLint?

@deetz99 deetz99 merged commit ed5e890 into bcgov:main Jan 3, 2025
40 of 43 checks passed
@deetz99 deetz99 deleted the linting branch January 3, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants