Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host - UI: Scenario 2 e2e test #437

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Conversation

deetz99
Copy link
Collaborator

@deetz99 deetz99 commented Jan 7, 2025

Issue:

Description of changes:

  • complete scenario 2 (str exempt) test
  • refactor tests to be more reusable
Screen.Recording.2025-01-06.at.4.03.31.PM.mov

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License

Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
27.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link
Contributor

@ser-popov ser-popov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-hosts-dev--pr-437-7fzcidql.web.app

@deetz99 deetz99 merged commit 6282e4e into bcgov:main Jan 7, 2025
15 of 16 checks passed
@deetz99 deetz99 deleted the scenario-2-e2e-test branch January 7, 2025 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants