Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

25160 25161 25162 25164 tweaks #439

Merged
merged 4 commits into from
Jan 7, 2025
Merged

25160 25161 25162 25164 tweaks #439

merged 4 commits into from
Jan 7, 2025

Conversation

kialj876
Copy link
Collaborator

@kialj876 kialj876 commented Jan 7, 2025

Issue:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License

@kialj876
UI - small fixes
a30e47b 
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
@kialj876
cleanup
4b390ba 
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
@kialj876 kialj876 requested a review from deetz99 January 7, 2025 21:19
@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-strata-hotel-dev--pr-439-s1q5w5nu.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-hosts-dev--pr-439-92djy9mw.web.app

deetz99
deetz99 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@deetz99 deetz99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that one comment about the watcher but other than that looks good 👍

@kialj876
cleanup
0104268 
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
@kialj876
cleanup
3b4646e 
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
4.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-examiner-dev--pr-439-b9bf5p3c.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-strata-hotel-dev--pr-439-s1q5w5nu.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-platform-dev--pr-439-2uncaxcs.web.app

@kialj876 kialj876 merged commit e2c673d into bcgov:main Jan 7, 2025
40 of 42 checks passed
@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-examiner-dev--pr-439-b9bf5p3c.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-platform-dev--pr-439-2uncaxcs.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-strata-hotel-dev--pr-439-s1q5w5nu.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-hosts-dev--pr-439-92djy9mw.web.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deetz99 deetz99 deetz99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kialj876 @bcregistry-sre @deetz99