feat: Updated Person Branding #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
swcurran
approved these changes
Mar 22, 2024
| "flagged_attributes": [ | ||
| "given_names", |
There was a problem hiding this comment.
Confirming with Marcos that these attributes are not PII. Since like at least the names and street address should be...
There was a problem hiding this comment.
@swcurran we have deflagged -- is that a word? -- most attributes in Person credential, and the new set (photo, DOB) is consistent with https://github.com/bcgov/bc-vcpedia/blob/main/guides/credential-ux-guide.md#flagged-attributes which states that "This overlay is intended to be used sparingly and is not meant for all personally identifiable information." That section of the UX Guide was reviewed and okayed by Oliver.
|
The PII question can be addressed with a follow up PR if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the Person branding per the IDIM team's request