Skip to content

Commit

Permalink
BRS-361 Increase variance note character limit to 200
Browse files Browse the repository at this point in the history
  • Loading branch information
cameronpettit committed Oct 25, 2024
1 parent 43b7724 commit 4e67729
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export class BackcountryCabinsComponent extends RootFormComponent {
peopleChild: new UntypedFormControl(null, { nonNullable: true, validators: [Validators.min(0), this.varianceFieldInvalidator('peopleChild')] }),
peopleFamily: new UntypedFormControl(null, { nonNullable: true, validators: [Validators.min(0), this.varianceFieldInvalidator('peopleFamily')] }),
revenueFamily: new UntypedFormControl(null, { nonNullable: true, validators: [Validators.min(0), this.varianceFieldInvalidator('revenueFamily')] }),
notes: new UntypedFormControl(null, { nonNullable: true, validators: [Validators.maxLength(100)] }),
notes: new UntypedFormControl(null, { nonNullable: true, validators: [Validators.maxLength(this.maxVarianceNotesCharacters)] }),
});
this.calculateTotals();
this.form?.valueChanges.subscribe(() => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export class BackcountryCampingComponent extends RootFormComponent {
this.form = new UntypedFormGroup({
people: new UntypedFormControl(null, { nonNullable: true, validators: [Validators.min(0), this.varianceFieldInvalidator('people')] }),
grossCampingRevenue: new UntypedFormControl(null, { nonNullable: true, validators: [Validators.min(0), this.varianceFieldInvalidator('grossCampingRevenue')] }),
notes: new UntypedFormControl(null, { nonNullable: true, validators: [Validators.maxLength(100)] }),
notes: new UntypedFormControl(null, { nonNullable: true, validators: [Validators.maxLength(this.maxVarianceNotesCharacters)] }),
});
this.calculateTotals();
this.form?.valueChanges.subscribe(() => {
Expand Down
2 changes: 1 addition & 1 deletion src/app/forms/boating/boating.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export class BoatingComponent extends RootFormComponent {
boatAttendanceNightsOnBouys: new UntypedFormControl(null, { nonNullable: true, validators: [Validators.min(0), this.varianceFieldInvalidator('boatAttendanceNightsOnBouys')] }),
boatAttendanceNightsOnDock: new UntypedFormControl(null, { nonNullable: true, validators: [Validators.min(0), this.varianceFieldInvalidator('boatAttendanceNightsOnDock')] }),
boatRevenueGross: new UntypedFormControl(null, { nonNullable: true, validators: [Validators.min(0), this.varianceFieldInvalidator('boatRevenueGross')] }),
notes: new UntypedFormControl(null, { nonNullable: true, validators: [Validators.maxLength(100)] }),
notes: new UntypedFormControl(null, { nonNullable: true, validators: [Validators.maxLength(this.maxVarianceNotesCharacters)] }),
});
this.calculateTotals();
this.form?.valueChanges.subscribe(() => {
Expand Down
2 changes: 1 addition & 1 deletion src/app/forms/day-use/day-use.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export class DayUseComponent extends RootFormComponent {
otherDayUseRevenueHotSprings: new UntypedFormControl(null, { nonNullable: true, validators: [Validators.min(0), this.varianceFieldInvalidator('otherDayUseRevenueHotSprings')] }),
picnicRevenueGross: new UntypedFormControl(null, { nonNullable: true, validators: [Validators.min(0), this.varianceFieldInvalidator('picnicRevenueGross')] }),
picnicRevenueShelter: new UntypedFormControl(null, { nonNullable: true, validators: [Validators.min(0), this.varianceFieldInvalidator('picnicRevenueShelter')] }),
notes: new UntypedFormControl(null, { nonNullable: true, validators: [Validators.maxLength(100)] }),
notes: new UntypedFormControl(null, { nonNullable: true, validators: [Validators.maxLength(this.maxVarianceNotesCharacters)] }),
});
this.calculateTotals();
this.form?.valueChanges.subscribe(() => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export class FrontcountryCabinsComponent extends RootFormComponent {
this.form = new UntypedFormGroup({
totalAttendanceParties: new UntypedFormControl(null, { nonNullable: true, validators: [Validators.min(0), this.varianceFieldInvalidator('totalAttendanceParties')] }),
revenueGrossCamping: new UntypedFormControl(null, { nonNullable: true, validators: [Validators.min(0), this.varianceFieldInvalidator('revenueGrossCamping')] }),
notes: new UntypedFormControl(null, { nonNullable: true, validators: [Validators.maxLength(100)] }),
notes: new UntypedFormControl(null, { nonNullable: true, validators: [Validators.maxLength(this.maxVarianceNotesCharacters)] }),
});
this.calculateTotals();
this.form?.valueChanges.subscribe(() => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export class FrontcountryCampingComponent extends RootFormComponent {
otherRevenueGrossSani: new UntypedFormControl(null, { nonNullable: true, validators: [Validators.min(0), this.varianceFieldInvalidator('otherRevenueGrossSani')] }),
otherRevenueShower: new UntypedFormControl(null, { nonNullable: true, validators: [Validators.min(0), this.varianceFieldInvalidator('otherRevenueShower')] }),
secondCarsRevenueGross: new UntypedFormControl(null, { nonNullable: true, validators: [Validators.min(0), this.varianceFieldInvalidator('secondCarsRevenueGross')] }),
notes: new UntypedFormControl(null, { nonNullable: true, validators: [Validators.maxLength(100)] }),
notes: new UntypedFormControl(null, { nonNullable: true, validators: [Validators.maxLength(this.maxVarianceNotesCharacters)] }),
});
this.calculateTotals();
this.form?.valueChanges.subscribe(() => {
Expand Down
2 changes: 1 addition & 1 deletion src/app/forms/group-camping/group-camping.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export class GroupCampingComponent extends RootFormComponent {
youthRateGroupsAttendancePeople: new UntypedFormControl(null, { nonNullable: true, validators: [Validators.min(0), this.varianceFieldInvalidator('youthRateGroupsAttendancePeople')] }),
standardRateGroupsRevenueGross: new UntypedFormControl(null, { nonNullable: true, validators: [Validators.min(0), this.varianceFieldInvalidator('standardRateGroupsRevenueGross')] }),
youthRateGroupsRevenueGross: new UntypedFormControl(null, { nonNullable: true, validators: [Validators.min(0), this.varianceFieldInvalidator('youthRateGroupsRevenueGross')] }),
notes: new UntypedFormControl(null, { nonNullable: true, validators: [Validators.maxLength(100)] }),
notes: new UntypedFormControl(null, { nonNullable: true, validators: [Validators.maxLength(this.maxVarianceNotesCharacters)] }),
});
this.calculateTotals();
this.form?.valueChanges.subscribe(() => {
Expand Down
1 change: 1 addition & 0 deletions src/app/forms/root-form/root-form.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export class RootFormComponent implements OnInit, OnDestroy {
public showVarianceModal: boolean = false;
public activityType;
public accordionType;
public maxVarianceNotesCharacters = 200;
public invalidConfig = {
showMessage: false
};
Expand Down

0 comments on commit 4e67729

Please sign in to comment.