Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BRS-359-4: Revert BaseHref Change #379

Merged
merged 2 commits into from
Sep 11, 2024
Merged

BRS-359-4: Revert BaseHref Change #379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8017180
revert basehref change
davidclaveau Sep 11, 2024
e55f272
revert basehref change in deploys
davidclaveau Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/deploy_dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ jobs:
API_STAGE: ${{ vars.AR_API_STAGE }}
DOMAIN_NAME: ${{ vars.DOMAIN_NAME }}
AWS_CERTIFICATE_ARN: ${{ vars.AWS_CERTIFICATE_ARN }}
BASE_HREF: ""
BASE_HREF: "/"
run: |
sam deploy --stack-name $STACK_NAME --no-confirm-changeset --no-fail-on-empty-changeset --parameter-overrides \
"ProjectName=$PROJECT_NAME \
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy_prod.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ jobs:
API_STAGE: ${{ vars.AR_API_STAGE }}
DOMAIN_NAME: ${{ vars.DOMAIN_NAME }}
AWS_CERTIFICATE_ARN: ${{ vars.AWS_CERTIFICATE_ARN }}
BASE_HREF: ""
BASE_HREF: "/"
run: |
sam deploy --stack-name $STACK_NAME --no-confirm-changeset --no-fail-on-empty-changeset --parameter-overrides \
"ProjectName=$PROJECT_NAME \
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ jobs:
API_STAGE: ${{ vars.AR_API_STAGE }}
DOMAIN_NAME: ${{ vars.DOMAIN_NAME }}
AWS_CERTIFICATE_ARN: ${{ vars.AWS_CERTIFICATE_ARN }}
BASE_HREF: ""
BASE_HREF: "/"
run: |
sam deploy --stack-name $STACK_NAME --no-confirm-changeset --no-fail-on-empty-changeset --parameter-overrides \
"ProjectName=$PROJECT_NAME \
Expand Down
7 changes: 4 additions & 3 deletions template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ Parameters:
Description: AWS Region.
BaseHref:
Type: String
Default: "/"
Description: Base href to use for cloudfront.
DistOriginPath:
Type: String
Expand Down Expand Up @@ -79,18 +80,18 @@ Resources:
CustomErrorResponses:
- ErrorCode: 404
ResponseCode: 200
ResponsePagePath: !Sub /${BaseHref}index.html
ResponsePagePath: !Sub ${BaseHref}index.html
- ErrorCode: 403
ResponseCode: 200
ResponsePagePath: !Sub /${BaseHref}index.html
ResponsePagePath: !Sub ${BaseHref}index.html
Aliases:
- !Ref EnvDomainName
ViewerCertificate:
AcmCertificateArn: !Ref DomainCertificateArn
SslSupportMethod: sni-only
MinimumProtocolVersion: TLSv1
Comment: !Sub "CloudFront distribution for ${AWS::StackName}"
DefaultRootObject: !Sub ${BaseHref}index.html
DefaultRootObject: !Sub index.html
Enabled: true
HttpVersion: http2
# List of origins that Cloudfront will connect to
Expand Down
Loading