Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

233: Hookup A&R to Data Register. #267

Merged
merged 8 commits into from
Oct 30, 2023
Merged

233: Hookup A&R to Data Register. #267

merged 8 commits into from
Oct 30, 2023

Conversation

marklise
Copy link
Contributor

Fixes #233

Two new environment variables have been setup - their default configurations are setup in the parameter store.

There is a cronjob that is setup to run every midnight. The first run of the job will update ALL names in the A&R table to whatever they are set to in the data register. On subsequent runs, the code will only update the records in question that have changed from the data register.

A new index against the A&R table is setup (orcs-index) which allows the code to efficiently query all records via orcs.

TODO: Update the parameter store variables with TEST and PROD data that point to the appropriate API endpoint for DR TEST and PROD.

Copy link
Contributor

@cameronpettit cameronpettit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would point DEV, TEST and PROD all to the prod instance of Data Register - its an entirely different project, we should be able to assume it's complete and functional for the contexts of the DEV/TEST A&R environments.

Obviously though we don't have a vanity prod URL for Data Register - I would say you can merge this but the ticket should be moved to blocked.

@cameronpettit
Copy link
Contributor

To add to my above comment - consider the the future case where A&R and the Data Register are potentially handed off to two different maintenance teams. I'm not sure it would be best to have the testing envs of one project be reliant on the testing envs of another when a future maintenance team may not have access to both.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@marklise marklise merged commit 52f2da2 into bcgov:main Oct 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

[L] Connect Attendance & Revenue to Park Name Register
4 participants