Skip to content

Commit

Permalink
- app version = 5.10.9 (#690)
Browse files Browse the repository at this point in the history
- updated Continuation Authorization layout
- removed continuation authorization authority name
- added continuation authorization date hints
- removed continuation authorization confirmation checkbox
- updated continuation authorization header blurb
- updated review page
- deleted authorityName and isConfirmed from component interfaces
- added businessFoundingDate to API interface
- updated filing resume code (parse)
- update Your Business in Home Jurisdiction icon
- updated/added unit tests
- misc cleanup

Co-authored-by: Severin Beauvais <severin.beauvais@gov.bc.ca>
  • Loading branch information
severinbeauvais and Severin Beauvais authored May 16, 2024
1 parent 8fe99e0 commit c57ae41
Show file tree
Hide file tree
Showing 13 changed files with 300 additions and 265 deletions.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "business-create-ui",
"version": "5.10.8",
"version": "5.10.9",
"private": true,
"appName": "Create UI",
"sbcName": "SBC Common Components",
Expand Down
158 changes: 57 additions & 101 deletions src/components/ContinuationIn/ContinuationAuthorization.vue
Original file line number Diff line number Diff line change
Expand Up @@ -7,91 +7,12 @@
v-if="authorization"
id="continuation-authorization"
>
<header>
<p>
Upload the continuation authorization letter from your home jursidiction.
</p>

<ul>
<li>
Use a white background and a legible font with contrasting font colour
</li>
<li>
PDF file type (maximum 30 MB file size)
</li>
</ul>
</header>

<div class="pt-4" />

<v-row
v-for="(num, index) in numUploads"
:key="authorization.files[index]?.fileKey"
class="upload-file-row mt-4 mb-n2"
no-gutters
>
<v-col
cols="12"
sm="3"
>
<label v-if="index === 0">Upload File (5 maximum)</label>
</v-col>
<v-col
cols="12"
sm="9"
>
<FileUploadPreview
inputFileLabel="Continuation authorization"
:maxSize="MAX_FILE_SIZE"
:pdfPageSize="PdfPageSize.LETTER_SIZE"
:hint="authorization.files[index]?.file ? 'File uploaded' : undefined"
:inputFile="authorization.files[index]?.file"
:showErrors="getShowErrors"
:customErrorMessage.sync="customErrorMessage[index]"
:isRequired="getShowErrors && (index === 0)"
@fileValidity="onFileValidity($event)"
@fileSelected="onFileSelected(index, $event)"
/>
</v-col>
</v-row>
<v-form
ref="formRef"
lazy-validation
@submit.prevent
>
<v-row
class="mt-6"
no-gutters
>
<v-col
cols="12"
sm="3"
>
<label>Authority Name</label>
</v-col>
<v-col
cols="12"
sm="9"
class="pl-8"
>
<v-text-field
v-model="authorization.authorityName"
class="authority-name"
filled
hide-details="auto"
label="Authority Name"
:rules="getShowErrors ? authorityNameRules : []"
/>
</v-col>
</v-row>
<v-row
class="mt-6"
no-gutters
>
<v-row no-gutters>
<v-col
cols="12"
sm="3"
Expand All @@ -109,6 +30,8 @@
title="Authorization Date"
:nudgeRight="40"
:nudgeTop="85"
hint="The date the authorization was issued."
:persistentHint="true"
:initialValue="authorization.date"
:inputRules="getShowErrors ? authorizationDateRules : []"
:maxDate="getCurrentDate"
Expand All @@ -118,7 +41,7 @@
</v-row>

<v-row
class="mt-6"
class="mt-2"
no-gutters
>
<v-col
Expand All @@ -138,26 +61,67 @@
title="Expiry Date (Optional)"
:nudgeRight="40"
:nudgeTop="85"
hint="The date the authorization expires."
:persistentHint="true"
:initialValue="authorization.expiryDate"
:inputRules="getShowErrors ? expiryDateRules: []"
:minDate="getCurrentDate"
@emitDateSync="authorization.expiryDate = $event"
/>
</v-col>
</v-row>
</v-form>

<v-divider class="mt-6 mb-8" />

<header>
<p>
Upload documents that support proof of authorization from your home jursidiction.
</p>

<ul>
<li>
Use a white background and a legible font with contrasting font colour
</li>
<li>
PDF file type (maximum 30 MB file size)
</li>
</ul>
</header>

<div class="pt-4" />

<v-row
v-for="(num, index) in numUploads"
:key="authorization.files[index]?.fileKey"
class="upload-file-row mt-4 mb-n2"
no-gutters
>
<v-col
cols="12"
sm="3"
>
<label v-if="index === 0">Upload File</label>
</v-col>
<v-checkbox
v-model="authorization.isConfirmed"
class="continuation-authorization-checkbox mt-7"
hide-details
:rules="getShowErrors ? [(v) => !!v] : []"
<v-col
cols="12"
sm="9"
>
<template #label>
<span>I confirm that I have current and valid authorization to continue this business into
B.C.</span>
</template>
</v-checkbox>
</v-form>
<FileUploadPreview
inputFileLabel="Continuation authorization"
:maxSize="MAX_FILE_SIZE"
:pdfPageSize="PdfPageSize.LETTER_SIZE"
:hint="authorization.files[index]?.file ? 'File uploaded' : undefined"
:inputFile="authorization.files[index]?.file"
:showErrors="getShowErrors"
:customErrorMessage.sync="customErrorMessage[index]"
:isRequired="getShowErrors && (index === 0)"
@fileValidity="onFileValidity($event)"
@fileSelected="onFileSelected(index, $event)"
/>
</v-col>
</v-row>
</div>
</template>
Expand Down Expand Up @@ -201,12 +165,6 @@ export default class ExtraproRegistration extends Mixins(DocumentMixin) {
fileValidity = false
customErrorMessage = ['', '', '', '', '']
get authorityNameRules (): Array<VuetifyRuleFunction> {
return [
(v: string) => !!v || 'Authority Name is required'
]
}
get authorizationDateRules (): Array<VuetifyRuleFunction> {
return [
() => !!this.authorization.date ||
Expand Down Expand Up @@ -313,10 +271,8 @@ export default class ExtraproRegistration extends Mixins(DocumentMixin) {
// then emit the validity
return (
(this.authorization.files.length >= 1) &&
!!this.authorization.authorityName &&
!!this.authorization.date &&
(this.authorization.isConfirmed === true)
(this.authorization.files.length >= 1)
)
}
}
Expand Down
1 change: 1 addition & 0 deletions src/components/ContinuationIn/ExtraproRegistration.vue
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@
>
<v-radio-group
v-model="business.isUlc"
class="mt-0 pt-0"
row
>
<v-radio
Expand Down
Loading

0 comments on commit c57ae41

Please sign in to comment.