NOBUG: Delete hold token from DB. (#394)

bcgov · May 22, 2024 · 975f837 · 975f837
1 parent be125c6
commit 975f837
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 1 deletion.
diff --git a/__tests__/writePass.test.js b/__tests__/writePass.test.js
@@ -547,6 +547,9 @@ describe('Pass Successes', () => {
             commit: true
           };
         }),
+        deleteHoldToken:jest.fn(() => {
+          return;
+        }),
         getOne: jest.fn(() => {
           return undefined // Simulate not found
         }),

diff --git a/lambda/permissionUtil.js b/lambda/permissionUtil.js
@@ -86,6 +86,22 @@ exports.verifyHoldToken = function (token, secret) {
   return decodedToken;
 };
 
+exports.deleteHoldToken = async function (token) {
+  try {
+    await dynamodb.deleteItem({
+      Key: {
+        pk: { S: 'jwt' },
+        sk: { S: token }
+      },
+      TableName: TABLE_NAME
+    }).promise();
+  } catch (error) {
+    // Handle the error here
+    logger.error('Error deleting hold token:');
+    logger.debug(error);
+  }
+};
+
 const verifyToken = function (token, callback, sendError) {
   logger.debug('verifying token');
   logger.debug('token:', token);

diff --git a/lambda/writePass/index.js b/lambda/writePass/index.js
@@ -23,7 +23,14 @@ const {
   storeObject
 } = require('../dynamoUtil');
 const { sendResponse, checkWarmup, CustomError } = require('../responseUtil');
-const { decodeJWT, resolvePermissions, validateToken, verifyHoldToken, getExpiryTime } = require('../permissionUtil');
+const {
+  decodeJWT,
+  deleteHoldToken,
+  getExpiryTime,
+  resolvePermissions,
+  validateToken,
+  verifyHoldToken
+} = require('../permissionUtil');
 const { DateTime } = require('luxon');
 const { logger } = require('../logger');
 const { createNewReservationsObj } = require('../reservationObjUtils');
@@ -175,6 +182,10 @@ async function handleCommitPass(newObject, isAdmin) {
       logger.error(error);
       return sendResponse(error.statusCode, { msg: error.message, title: 'Operation Failed.' });
     }
+
+    // Delete the JWT from the database
+    logger.info('Deleting the JWT from the database');
+    await deleteHoldToken(token);
   }
 
   logger.info('generateCancellationLink');