NOBUG: Update conditions (#401)

bcgov · Jun 11, 2024 · fc18501 · fc18501
1 parent c499a63
commit fc18501
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/lambda/dynamoUtil.js b/lambda/dynamoUtil.js
@@ -520,7 +520,8 @@ async function restoreAvailablePass(pk, sk, orcNumber, shortPassDate, facilityNa
           Key: {
             pk: { S: pk },
             sk: { S: sk }
-          }
+          },
+          ConditionExpression: 'attribute_exists (pk) AND attribute_exists (sk)'
         }
       },
       {
@@ -529,7 +530,8 @@ async function restoreAvailablePass(pk, sk, orcNumber, shortPassDate, facilityNa
           Key: {
             pk: { S: passPk },
             sk: { S: passSk }
-          }
+          },
+          ConditionExpression: 'attribute_exists (pk) AND attribute_exists (sk)'
         }
       }]
     };

diff --git a/lambda/writePass/index.js b/lambda/writePass/index.js
@@ -488,7 +488,7 @@ async function transactWriteWithRetries(transactionObj, maxRetries = 3) {
         cancellationReasons = cancellationReasons.slice(0, -1);
         cancellationReasons = cancellationReasons.split(', ');
         let message = error.message;
-        let reasonIndex = this.cancellationReasons.findIndex((i) => i !== 'None');
+        let reasonIndex = cancellationReasons.findIndex((i) => i !== 'None');
         if (reasonIndex > -1) {
           switch (reasonIndex) {
             case 0: