feat: #tno-2264 - updated ingestmanager to allow restart after pre-set delay #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kylgarmor
commented
Jan 29, 2024
•
kylgarmor
commented
- added new configuration value ResetRetryAfterDelayMs
- when RunAsAsync is called we check to see if the ingest has reach max failures
- if maxFailures hit, check if ResetRetryAfterDelayMs is set
- compare LastRunAt PLUS ResetRetryAfterDelayMs to UTC.Now
- if we are past the delay, reset the failure count and allow the service to move forward
- have set 1hr as the default reset interval to all existing ingests
…t delay - added new configuration value ResetRetryAfterDelayMs - when RunAsAsync is called we check to see if the ingest has reach max failures - if maxFailures hit, check if ResetRetryAfterDelayMs is set - compare LastRunAt PLUS ResetRetryAfterDelayMs to UTC.Now - if we are past the delay, reset the failure count and allow the service to move forward
kylgarmor
added
enhancement
Fosol
reviewed
Jan 29, 2024
| @@ -133,8 +133,15 @@ public override async Task RunAsync() | |||
| { | |||
| if (ingest.FailedAttempts >= ingest.RetryLimit) | |||
| { | |||
| this.Logger.LogWarning("Ingest '{name}' has reached maximum failure limit", ingest.Name); | |||
| continue; | |||
| if (ingest.LastRanOn.HasValue && ingest.ResetRetryAfterDelayMs > 0 | |||
There was a problem hiding this comment.
Will this then keep retrying after X ms until it is successful?
There was a problem hiding this comment.
yes. If want to, we could introduce another couple of values which track consecutive "resets" and "maxResetsAllowed".
Current implementation would hit maxFailures, then wait untl delay has passed and then reset failureCount and retry again.
Fosol
approved these changes
Jan 29, 2024
…t delay - added script to set default reset interval to 1hr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.