TNO-2056 Update report edit story #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fosol
added
enhancement
Publish tno-core:0.1.23
Fosol
commented
Jan 31, 2024
| @@ -229,12 +230,15 @@ public async Task<IActionResult> UpdateAsync(ContentModel model) | |||
| content.Summary = model.Summary; | |||
| content.Body = model.Body; | |||
| content.Versions = model.Versions; | |||
| content.TonePoolsManyToMany.ForEach(tp => | |||
| foreach (var tonePool in model.TonePools) | |||
There was a problem hiding this comment.
Not necessary, but was debugging a bug that I thought was occurring here.
| <FaRegMeh className="tone-icon" color="#FFC107" title={title} /> | ||
| </Show> | ||
| <Show visible={value !== undefined && value > 0}> | ||
| <FaRegSmile className="tone-icon" color="#20C997" title={title} /> | ||
| </Show> | ||
| {showValue && <span>{value}</span>} |
There was a problem hiding this comment.
We can now show the value
| @@ -147,7 +147,20 @@ public override ReportInstance Update(ReportInstance entity) | |||
| if (ric.Content != null) | |||
| { | |||
| // TODO: Small security issue as the JSON could lie about this data. | |||
| if (ric.Content.IsPrivate) | |||
| if (ric.Content.IsPrivate && | |||
There was a problem hiding this comment.
Only update content that has changed
| * @param param0 Component properties. | ||
| * @returns Component. | ||
| */ | ||
| export const SentimentPicker = <T extends object>({ |
There was a problem hiding this comment.
New basic component without Formik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subscriber reports now use a column approach when editing content. There is still more work to do on this functionality, but the basic workflow is coming together.
TODO
Summary
Edit Report (Existing Content)
Edit Report (Add Content)