-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TNO-2056 Update report edit story #1469
Conversation
Publish tno-core:0.1.23
@@ -229,12 +230,15 @@ public async Task<IActionResult> UpdateAsync(ContentModel model) | |||
content.Summary = model.Summary; | |||
content.Body = model.Body; | |||
content.Versions = model.Versions; | |||
content.TonePoolsManyToMany.ForEach(tp => | |||
foreach (var tonePool in model.TonePools) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessary, but was debugging a bug that I thought was occurring here.
<FaRegMeh className="tone-icon" color="#FFC107" title={title} /> | ||
</Show> | ||
<Show visible={value !== undefined && value > 0}> | ||
<FaRegSmile className="tone-icon" color="#20C997" title={title} /> | ||
</Show> | ||
{showValue && <span>{value}</span>} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can now show the value
@@ -147,7 +147,20 @@ public override ReportInstance Update(ReportInstance entity) | |||
if (ric.Content != null) | |||
{ | |||
// TODO: Small security issue as the JSON could lie about this data. | |||
if (ric.Content.IsPrivate) | |||
if (ric.Content.IsPrivate && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only update content that has changed
* @param param0 Component properties. | ||
* @returns Component. | ||
*/ | ||
export const SentimentPicker = <T extends object>({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New basic component without Formik
Subscriber reports now use a column approach when editing content. There is still more work to do on this functionality, but the basic workflow is coming together.
TODO
Summary
Edit Report (Existing Content)
Edit Report (Add Content)