TNO-2056 Update Report content editing #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fosol
added
bug
Fosol
commented
Feb 1, 2024
| @@ -123,118 +110,6 @@ export const ReportEdit: React.FC = () => { | |||
| } catch {} | |||
| }); | |||
|
|
|||
| const handleExport = React.useCallback( | |||
There was a problem hiding this comment.
Moved all this logic to a separate component ReportEditForm. This new component is the report editor with the tabs.
| @@ -0,0 +1,201 @@ | |||
| import { Button } from 'components/button'; | |||
There was a problem hiding this comment.
New component which is the right column for editing one content item at a time.
| @@ -1,32 +1,53 @@ | |||
| import { Action } from 'components/action'; | |||
There was a problem hiding this comment.
Updated component is the left column of the report editor.
| @@ -216,6 +223,9 @@ export const ReportSectionContent: React.FC<IReportSectionContentProps> = ({ | |||
|
|
|||
| return ( | |||
| <div | |||
| className={`${isSame ? 'active-content ' : ''}${ | |||
There was a problem hiding this comment.
Highlight active row(s). Duplicate content can be in more than one section.
Fosol
commented
Feb 1, 2024
| @@ -127,6 +127,8 @@ public override ReportInstance Update(ReportInstance entity) | |||
| }); | |||
| entity.ContentManyToMany.ForEach(ric => | |||
| { | |||
| // Duplicate content can be in multiple sections, so we grab the first copy. | |||
There was a problem hiding this comment.
Fixing issue where saving a report fails if the edited content is in more than one section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor report editing forms to resolve the WYSIWYG component performance issues.
Report Edit Form