-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TNO-2056 Update Report content editing #1478
Conversation
@@ -123,118 +110,6 @@ export const ReportEdit: React.FC = () => { | |||
} catch {} | |||
}); | |||
|
|||
const handleExport = React.useCallback( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved all this logic to a separate component ReportEditForm. This new component is the report editor with the tabs.
@@ -0,0 +1,201 @@ | |||
import { Button } from 'components/button'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New component which is the right column for editing one content item at a time.
@@ -1,32 +1,53 @@ | |||
import { Action } from 'components/action'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated component is the left column of the report editor.
@@ -216,6 +223,9 @@ export const ReportSectionContent: React.FC<IReportSectionContentProps> = ({ | |||
|
|||
return ( | |||
<div | |||
className={`${isSame ? 'active-content ' : ''}${ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Highlight active row(s). Duplicate content can be in more than one section.
@@ -127,6 +127,8 @@ public override ReportInstance Update(ReportInstance entity) | |||
}); | |||
entity.ContentManyToMany.ForEach(ric => | |||
{ | |||
// Duplicate content can be in multiple sections, so we grab the first copy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing issue where saving a report fails if the edited content is in more than one section.
Refactor report editing forms to resolve the WYSIWYG component performance issues.
Report Edit Form