[READY] Search Page - Add new list view #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jdtoombs
commented
Feb 6, 2024
•
jdtoombs
commented
- icon instead of text for opening in new window
- add content list to search page
- remove old code
jdtoombs
added
enhancement
Fosol
approved these changes
Feb 6, 2024
jdtoombs
commented
Feb 6, 2024
| const [init, setInit] = React.useState(true); // React hooks are horrible... | ||
|
|
||
| const filterId = id ? parseInt(id) : 0; | ||
|
|
||
| React.useEffect(() => { | ||
| if (isReady) { | ||
| const showPageIds = settings.find( |
There was a problem hiding this comment.
Implemented new window, need to re implement show page, currently just shows page number if one exists
jdtoombs
commented
Feb 6, 2024
| <FaBookmark /> | ||
| <div className="filter-name">{activeFilter?.name}</div> | ||
| </div> | ||
| </Show> | ||
| <Row className="search-contents"> |
There was a problem hiding this comment.
All this covered in ContentList
jdtoombs
commented
Feb 6, 2024
| @@ -144,132 +138,4 @@ export const SearchPage = styled.div` | |||
| margin-left: 0.5em; | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
All this covered in ContentList
jdtoombs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.