-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[READY] Search Page - Add new list view #1498
Conversation
jdtoombs
commented
Feb 6, 2024
•
edited
Loading
edited
- icon instead of text for opening in new window
- add content list to search page
- remove old code
const [init, setInit] = React.useState(true); // React hooks are horrible... | ||
|
||
const filterId = id ? parseInt(id) : 0; | ||
|
||
React.useEffect(() => { | ||
if (isReady) { | ||
const showPageIds = settings.find( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented new window, need to re implement show page, currently just shows page number if one exists
<FaBookmark /> | ||
<div className="filter-name">{activeFilter?.name}</div> | ||
</div> | ||
</Show> | ||
<Row className="search-contents"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All this covered in ContentList
@@ -144,132 +138,4 @@ export const SearchPage = styled.div` | |||
margin-left: 0.5em; | |||
} | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All this covered in ContentList