TNO-2526, TNO-2542: My folder fixes #1750
Conversation
jdtoombs
added
bug
| export interface IConfigureFolderProps { | ||
| active?: IFolderModel; | ||
| } | ||
| export interface IConfigureFolderProps {} |
There was a problem hiding this comment.
I've a PR that fixes issues related to this. While I like using contexts for shared components, I don't think that will fix the issues.
There was a problem hiding this comment.
But I'm all for it if you found it has fixed an issue.
There was a problem hiding this comment.
There was a place where we had another state variable that became out of sync and I replaced that with the context provider. Going to do some testing here though to see with the new changes
There was a problem hiding this comment.
I've marked it in a separate comment
| setCurrentFolder({ ...currentFolder, name: e.target.value } as IFolderModel) | ||
| } | ||
| value={active?.name ?? ''} | ||
| onChange={(e) => setActiveFolder({ ...active, name: e.target.value } as IFolderModel)} | ||
| /> | ||
| <h2>Folder automation settings</h2> | ||
| <Row> |
There was a problem hiding this comment.
@jdtoombs The checkbox on line 161 doesn't do anything. It needs to be hooked up to enabling the schedule.
| @@ -41,7 +41,6 @@ export const ConfigureFolder: React.FC<IConfigureFolderProps> = ({ active }) => | |||
|
|
|||
| const [activeFilter, setActiveFilter] = React.useState<IFilterModel>(); | |||
| const [actionName, setActionName] = React.useState<'delete' | 'empty'>(); | |||
| const [currentFolder, setCurrentFolder] = React.useState<IFolderModel>(); | |||
There was a problem hiding this comment.
This was the state variable becoming out of sync, and we don't really need it with context provider
With these updates, it should get rid of all errors when trying to save folders in any combination. Previously emptying the folder / trying to rename the folder would cause an error.