-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TNO-2527 Improve My Reports #1752
Conversation
Publish tno-core:0.1.54
/// <returns></returns> | ||
[HttpGet("{reportId}/instances")] | ||
[Produces(MediaTypeNames.Application.Json)] | ||
[ProducesResponseType(typeof(IEnumerable<ReportInstanceModel>), (int)HttpStatusCode.OK)] | ||
[ProducesResponseType(typeof(string), (int)HttpStatusCode.NoContent)] | ||
[SwaggerOperation(Tags = new[] { "Report" })] | ||
public IActionResult FindInstancesForReportId(int reportId, int? ownerId) | ||
public IActionResult FindInstancesForReportId(int reportId, int? ownerId, int? page, int? qty) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can page through history now
bottom: 0; | ||
left: 0; | ||
right: 0; | ||
inset-block-end: 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work.
@@ -3,7 +3,7 @@ import styled from 'styled-components'; | |||
export const ReportEditForm = styled.div` | |||
display: flex; | |||
flex-direction: column; | |||
overflow-x: auto; | |||
overflow-x: clip; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kkwangsir This line broke the stick footers that provide the action buttons for each form. Switching from auto
to clip
appears to work. Can you provide the reason for adding overflow-x: auto
here?
@@ -9,7 +9,7 @@ export const formatDate = (date: string | Date, includeTime?: boolean): string = | |||
const result = moment(date); | |||
if (!result.isValid()) return ''; | |||
if (includeTime) { | |||
return result.format('MMMM DD, YYYY hh:mm:ss'); | |||
return result.format('MMMM DD, YYYY hh:mm:ss a'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed issue as without the a
it was impossible to know if it was morning or evening.
@@ -19,4 +19,4 @@ data: | |||
MAX_FAIL_LIMIT: "5" | |||
TOPICS: notify | |||
CHES_EMAIL_ENABLED: "true" | |||
CHES_EMAIL_AUTHORIZED: "false" | |||
CHES_EMAIL_AUTHORIZED: "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed bug introduced in DevOps changes.
Added a way for subscribers to view their past report history.
Summary
Report History