TNO-2527 Improve My Reports #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Publish tno-core:0.1.54
Fosol
added
enhancement
Fosol
commented
Apr 25, 2024
| /// <returns></returns> | ||
| [HttpGet("{reportId}/instances")] | ||
| [Produces(MediaTypeNames.Application.Json)] | ||
| [ProducesResponseType(typeof(IEnumerable<ReportInstanceModel>), (int)HttpStatusCode.OK)] | ||
| [ProducesResponseType(typeof(string), (int)HttpStatusCode.NoContent)] | ||
| [SwaggerOperation(Tags = new[] { "Report" })] | ||
| public IActionResult FindInstancesForReportId(int reportId, int? ownerId) | ||
| public IActionResult FindInstancesForReportId(int reportId, int? ownerId, int? page, int? qty) |
There was a problem hiding this comment.
We can page through history now
| bottom: 0; | ||
| left: 0; | ||
| right: 0; | ||
| inset-block-end: 0; |
| @@ -3,7 +3,7 @@ import styled from 'styled-components'; | |||
| export const ReportEditForm = styled.div` | |||
| display: flex; | |||
| flex-direction: column; | |||
| overflow-x: auto; | |||
| overflow-x: clip; | |||
There was a problem hiding this comment.
@kkwangsir This line broke the stick footers that provide the action buttons for each form. Switching from auto to clip appears to work. Can you provide the reason for adding overflow-x: auto here?
| @@ -9,7 +9,7 @@ export const formatDate = (date: string | Date, includeTime?: boolean): string = | |||
| const result = moment(date); | |||
| if (!result.isValid()) return ''; | |||
| if (includeTime) { | |||
| return result.format('MMMM DD, YYYY hh:mm:ss'); | |||
| return result.format('MMMM DD, YYYY hh:mm:ss a'); | |||
There was a problem hiding this comment.
Fixed issue as without the a it was impossible to know if it was morning or evening.
| @@ -19,4 +19,4 @@ data: | |||
| MAX_FAIL_LIMIT: "5" | |||
| TOPICS: notify | |||
| CHES_EMAIL_ENABLED: "true" | |||
| CHES_EMAIL_AUTHORIZED: "false" | |||
| CHES_EMAIL_AUTHORIZED: "true" | |||
There was a problem hiding this comment.
Fixed bug introduced in DevOps changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a way for subscribers to view their past report history.
Summary
Report History