TNO-2501 Fix My Folders #1753
Merged
TNO-2501 Fix My Folders #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fosol
added
bug
Publish tno-core:0.1.55
Fosol
commented
Apr 25, 2024
| /// <returns></returns> | ||
| [HttpPut("{id}")] | ||
| [Produces(MediaTypeNames.Application.Json)] | ||
| [ProducesResponseType(typeof(FolderModel), (int)HttpStatusCode.OK)] | ||
| [ProducesResponseType(typeof(ErrorResponseModel), (int)HttpStatusCode.BadRequest)] | ||
| [SwaggerOperation(Tags = new[] { "Folder" })] | ||
| public IActionResult Update(FolderModel model) | ||
| public IActionResult Update(FolderModel model, bool updateContent = false) |
There was a problem hiding this comment.
We need this flag to allow us to update a folder without touching the content in it.
| @@ -51,6 +51,10 @@ export const ConfigureFolder: React.FC<IConfigureFolderProps> = ({ active }) => | |||
| if (myFolders.length) setInit(true); | |||
| }, [myFolders.length]); | |||
|
|
|||
| React.useEffect(() => { | |||
There was a problem hiding this comment.
@jdtoombs This is how a passed prop can update state.
| @@ -122,7 +126,7 @@ export const ConfigureFolder: React.FC<IConfigureFolderProps> = ({ active }) => | |||
| const handleSaveFolder = React.useCallback( | |||
| async (values: IFolderModel) => { | |||
| try { | |||
| const result = await updateFolder(values); | |||
| const result = await updateFolder(values, false); | |||
There was a problem hiding this comment.
Don't touch the content!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug where content was being removed from folder when the folder schedule was updated.
Summary
My Folders