TNO-2598 Update Reports #1766
Merged
TNO-2598 Update Reports #1766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fosol
added
enhancement
Fosol
commented
May 1, 2024
| @@ -150,7 +150,7 @@ export const ReportEditPage = () => { | |||
| // Report has been updated, go fetch latest. | |||
| // TODO: This can blow away a users' changes. | |||
| try { | |||
| if (message.id === report.id) { | |||
| if (message.reportId === report.id) { | |||
| @@ -0,0 +1,123 @@ | |||
| --- | |||
| apiVersion: v1 | |||
| kind: ServiceAccount | |||
There was a problem hiding this comment.
Fixed DevOps issue in DEV
Publish tno-core:0.1.56
kylgarmor
reviewed
May 1, 2024
| label="Empty report when starting next report" | ||
| checked={!values.settings.content.copyPriorInstance} | ||
| tooltip="If this is off an auto report will not generate a new report if an active one already exists." |
There was a problem hiding this comment.
"off" is a funny word here for me. I think "not set" might be better? Also, add a comma for after "off" ;)
| @@ -92,11 +92,37 @@ export const ReportEditSendForm = ({ onPublish, onGenerate }: IReportEditSendFor | |||
| <p> | |||
| An Auto Report is created for you on a schedule, but sent manually. If the report is | |||
| not sent before the next scheduled run, it will <strong>not</strong> generate a new | |||
| report. | |||
| report unless you select 'Empty report when staring next report'. | |||
There was a problem hiding this comment.
typo "staring" should be "starting"
|
|
||
| <Col className="info"> | ||
| <p> | ||
| A schedule that has already populated a report in a given day, will not attempt to do so |
There was a problem hiding this comment.
no comma needed here after "day"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the workflow and UI to inform a user what will occur if they keep an active report instance and turn on the auto report functionality. Also provided a way to control how it will work.
Summary
Subscriber Edit Report