TNO-2598 Fix Reporting Service #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fosol
added
bug
Fosol
commented
May 1, 2024
| @@ -18,4 +18,4 @@ data: | |||
| MAX_FAIL_LIMIT: "5" | |||
| TOPICS: index | |||
| CHES_EMAIL_ENABLED: "true" | |||
| CHES_EMAIL_AUTHORIZED: "false" | |||
| CHES_EMAIL_AUTHORIZED: "true" | |||
There was a problem hiding this comment.
Mistakenly set this as false in a few places.
| @@ -703,7 +703,7 @@ private async Task GenerateReportAsync(ReportRequestModel request, API.Areas.Ser | |||
| await HandleChesEmailOverrideAsync(request.RequestorId); | |||
|
|
|||
| var contexts = new List<EmailContextModel>(); | |||
| if (!String.IsNullOrWhiteSpace(request.To)) | |||
| if (!String.IsNullOrWhiteSpace(request.To) && request.To.IsValidEmail()) | |||
There was a problem hiding this comment.
The downside to this is it will ignore invalid email addresses and will hide a possible issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing invalid email so that reports and notifications will not fail.
Also corrected DevOps configuration to enable email in TEST.