Fix Notification Service #2186
Merged
Fix Notification Service #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fosol
commented
Aug 16, 2024
| @@ -27,7 +27,7 @@ | |||
| <div style="font-size:22px; font-weight:500;"><p>@(Settings.Subject.ShowTodaysDate ? $" {ReportExtensions.GetTodaysDate():dd-MMM-yyyy}" : "")</p></div> | |||
| </a> | |||
|
|
|||
| @if (Content.Count() == 0) | |||
| @if (Content.Count() == 0 && !ViewOnWebOnly) | |||
There was a problem hiding this comment.
Don't display this message for a link only report.
| <div style="font-size:22px; font-weight:500;"><p>@(Settings.Subject.ShowTodaysDate ? $" {ReportExtensions.GetTodaysDate():dd-MMM-yyyy}" : "")</p></div> | ||
| </a> | ||
|
|
||
| @if (Content.Count() == 0 && !ViewOnWebOnly) |
| @@ -307,9 +307,9 @@ private async Task ProcessSourceContentAsync(ConsumeResult<string, SourceContent | |||
| if (content != null) | |||
| { | |||
| if (updateContent) | |||
| Logger.LogInformation("Received updated content from TNO. Forcing an update to the MMI Content : {Source}:{Title}", model.Source, model.Title); | |||
| Logger.LogInformation("Received updated content. Forcing an update to the MMI Content : {Source}:{Title}", model.Source, model.Title); | |||
There was a problem hiding this comment.
This has nothing to do with TNO
| /// <param name="notification"></param> | ||
| /// <param name="content"></param> | ||
| /// <returns></returns> | ||
| private async Task<IEnumerable<API.Areas.Services.Models.Notification.UserModel>> GetNotificationSubscribersAsync(API.Areas.Services.Models.Notification.NotificationModel notification, API.Areas.Services.Models.Content.ContentModel content) |
There was a problem hiding this comment.
I was unable to duplicate subscriber issues, but there was a bug with distribution. I have also moved this logic from the NotificationValidator to here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issues related to notifications. Specifically identifying which users should receive one.
Also including fix for empty reports.
Summary