Fix Notification Service #2187
Merged
Fix Notification Service #2187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fosol
commented
Aug 16, 2024
| @@ -385,7 +385,8 @@ export const ViewContent: React.FC<IViewContentProps> = ({ setActiveContent, act | |||
| isAV && | |||
| !content?.source?.disableTranscribe && | |||
| !content.isApproved && | |||
| !isTranscriptRequestor | |||
| !isTranscriptRequestor && | |||
| !!content?.fileReferences.length | |||
There was a problem hiding this comment.
Don't allow asking for a transcript if there is no file.
| @@ -411,7 +407,8 @@ private async Task ResetAlertAsync(API.Areas.Services.Models.Content.ContentMode | |||
| subscribers.AddRange(content.UserNotifications.Where(cun => cun.User != null && cun.IsSubscribed && cun.User.AccountType != UserAccountType.Distribution) | |||
| .Select(cun => new API.Areas.Services.Models.Notification.UserModel(cun.User!))); | |||
|
|
|||
| return subscribers; | |||
| // Remove duplicate subscribers. This can occur if a user is both subscribed to the content and the notification. | |||
| return subscribers.GroupBy(s => s.Id).Select(s => s.First()); | |||
There was a problem hiding this comment.
Only return unique users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users should not receive duplicate notifications.