Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MMI-3116 Update Source and Series CBRA source #2354

Merged
merged 5 commits into from
Dec 5, 2024
Merged

MMI-3116 Update Source and Series CBRA source #2354

merged 5 commits into from
Dec 5, 2024

Conversation

laidaoyu
Copy link
Collaborator

@laidaoyu laidaoyu commented Dec 3, 2024

  • added is CBRA source to source and series page
  • updated source and series data models

@laidaoyu
MMI-3116 Update Source and Series CBRA source
a06d5b9 
- added is CBRA source to source and series page
- updated source and series data models
@laidaoyu laidaoyu self-assigned this Dec 3, 2024
Fosol
Fosol reviewed Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@Fosol Fosol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did the DB migration go?

@laidaoyu
Copy link
Collaborator Author

laidaoyu commented Dec 4, 2024

Where did the DB migration go?

they are in libs/net/dal/Migrations/20241129161926_1.3.8.cs and 20241129161926_1.3.8.Designer.cs

@Fosol
Copy link
Collaborator

Fosol commented Dec 4, 2024

Odd, when I reviewed last night it only showed 4 file changes in the PR.

Fosol
Fosol approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@Fosol Fosol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to run the DB migration manually with the helper scripts. Openshift can't handle the build of the db-migration service regrettably.

@JacobWang-bc JacobWang-bc merged commit b6ebdc4 into dev Dec 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fosol Fosol Fosol approved these changes

@JacobWang-bc JacobWang-bc Awaiting requested review from JacobWang-bc

@nehalaggarwal-bcgov nehalaggarwal-bcgov Awaiting requested review from nehalaggarwal-bcgov

Assignees

@laidaoyu laidaoyu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laidaoyu @Fosol @JacobWang-bc