Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACA-Py 1.0.1 update #1398

Merged
merged 2 commits into from
Oct 16, 2024
Merged

ACA-Py 1.0.1 update #1398

merged 2 commits into from
Oct 16, 2024

Conversation

loneil
Copy link
Contributor

@loneil loneil commented Oct 15, 2024

Use aca-py 1.0.1 image, plugins repo tag update

Not updating references to OWF yet, upcoming in 1.1.0

Update Traction display version to 1.0.0, figure next release which includes ACA-Py 1.x.x update we'd want to update major version? Otherwise could do 0.6.0

Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
Copy link
Contributor

@jamshale jamshale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya. have a major version is usually when it's mature and in production which traction certainly is.

@loneil loneil mentioned this pull request Oct 16, 2024
Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Regarding the TenantUI versioning scheme: we could follow the numbering ACA-Py uses in general (that is, also in the innkeeper plugin which we never update version-wise). I am however wondering if we should just version things independently since no real big change has been pushed to the application itself...

@loneil
Copy link
Contributor Author

loneil commented Oct 16, 2024

We may do multiple Traction releases on a single ACA-Py version though. But yeah the "Tenant UI version" is really just something to have in the package JSONs and I always just match it to what the release tag for Traction is.

Technically I guess someone could out-of-sync the 2 and have Traction on release 1.4.2 and the Tenant UI still on 1.1.1 or something (might have some things not work properly though) so the individual version number would at least tell them about the version syncing

@loneil loneil merged commit 255c387 into main Oct 16, 2024
12 checks passed
@loneil loneil deleted the chore/acaPy101 branch October 22, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants