-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT MERGE - Per Tenant Logging Testing #875
Conversation
Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>
…r_tenant_logging Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>
Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>
Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>
…r_tenant_logging
@shaangill025 the permission error we are seeing when creating the log file in OpenShift could be resolved by having the logs go into |
@esune I made the change in the following commit to allow |
Thank you @shaangill025, i think I follow now. Looping in @WadeBarnes for potential input/insight on the operations end. |
For anyone using the ACA-Py images the |
@WadeBarnes — are you now happy with the implementation in ACA-Py? As in approving the PR? @shaangill025 — two of the test Actions are failing in the ACA-Py PR. Could you please investigate and address them? We’ve had some trouble with the JSON-LD tests failing to resolve a URL that could be the cause of the integration test errors (or not…), but that would not be the issue with the other failing action. |
I've been letting @esune lead on the review of the Per Tenant Logging. I'm just commenting on the default location used for ACA-Py when it logs to disk. The images setup a |
The pods associated with this PR are still in a crash loop. |
…r_tenant_logging
Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>
Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>
…r_tenant_logging
Deployment URLs ready for review. |
@shaangill025 do we need to do more testing on this or are we good since the changes were incorporated in ACA-Py and we can therefore close the PR? |
We can close this PR as the associated changes are already merged in ACA-Py. |
No description provided.