OOB invitations #885
Merged
OOB invitations #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployment URLs ready for review. |
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
This reverts commit 321d291. Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
loneil
force-pushed
the
feature/oobTenantUi
branch
from
c42aea3
to
ede01ba
Compare
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
|
The failing tests were probably a bit to fragile. Changing the table columns would make them fail. Could just remove the failing test or update it with the expected column value. |
@jamshale yeah sorry had that fixed (forgot to push) but got sidetracked with other PRs and hadn't requests a review on this one yet. |
jamshale
reviewed
Oct 24, 2023
...ices/tenant-ui/frontend/src/components/connections/createConnection/CreateConnectionForm.vue
Show resolved
Hide resolved
jamshale
reviewed
Oct 24, 2023
services/tenant-ui/frontend/test/components/connections/Invitations.test.ts
Outdated
Show resolved
Hide resolved
jamshale
previously approved these changes
Oct 24, 2023
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
jamshale
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow choice between OOB connection type and connections/1.0 for creating an invitation.
Supports simple invitation protocol, can consider expanding to more complex handshake procotol stuff in the future but that would be best with a URL shortening plan (QR code definitely could have issues)