Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove null pointer in oca plugin schema #909

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

jamshale
Copy link
Contributor

@jamshale jamshale commented Nov 9, 2023

Not sure when this broke but the variable this schema example reference must have been removed. Also the marshmallow library might have changed. It should probably have been using named references.

Weird it didn't throw errors.

Should consider running the ruff linting on the plugins to catch something like this.

Signed-off-by: jamshale <jamiehalebc@gmail.com>
@esune
Copy link
Member

esune commented Nov 9, 2023

@jamshale is linting set-up in the plugins repo such that we could follow that example to lint plugins here that will not be moved?

@jamshale
Copy link
Contributor Author

jamshale commented Nov 9, 2023

@esune There is now yes. You install a poetry plugin and then navigate to the repo and then run poetry run ruff check .
It's pretty simple. My vscode picked this up right away though, because I have the ruff extension installed.

@jamshale jamshale merged commit 5261347 into main Nov 9, 2023
11 checks passed
@jamshale
Copy link
Contributor Author

jamshale commented Nov 9, 2023

@esune Actually the plugins in traction aren't using ruff yet. Maybe they should be updated to use ruff and then conform to the same rules as acapy like the plugin repo. I think this could wait until we remove the plugins that are already in the plugin repo.

@loneil loneil deleted the feat/902-fix-oca-endpoints branch June 11, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants