Expose server settings to Innkeeper UI and Tenant UI via plugin routes #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployment URLs ready for review. |
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
loneil
force-pushed
the
feature/innkeeperSettings
branch
from
026314e
to
0896178
Compare
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
jamshale
reviewed
Nov 15, 2023
plugins/traction_innkeeper/traction_innkeeper/v1_0/innkeeper/routes.py
Outdated
Show resolved
Hide resolved
jamshale
reviewed
Nov 15, 2023
services/tenant-ui/frontend/src/components/innkeeper/config/ServerConfig.vue
Outdated
Show resolved
Hide resolved
jamshale
previously approved these changes
Nov 15, 2023
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
loneil
changed the title
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
jamshale
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugin
Add in endpoints to the Innkeeper plugin to allow Innkeepers and Tenants to access ACA-Py server config.
There is a unsecured (for multitenancy, secured with x-api-key) endpoint
/server/status/configso extend that in the Innkeeper and Tenant endpoints so it can be fetched with tenant JWTs. Also extend it/remove things as appropriate.Keep the "/server/status/config" pathing, even if it's a bit verbose in these 2 new spots
/innkeeper/server/status/configAdd aca-py version, ensure innkeeper wallet key does not get returned.
/tenant/server/status/configAdd version, remove a number of things a tenant does not need to access.
See
plugins/traction_innkeeper/traction_innkeeper/v1_0/tenant/routes.pyin files changed for details.Tenant UI - Innkeeper
Add a "Server Configuration" page for the Innkeeper that displays a dashboard of
Break it down into some visual sections for important things.
Allow full settings view with expanders at the bottom
Tenant UI - Tenant
Just show the raw data on the Settings page.
I'm not sure how useful this is to a Tenant, but they might need to troubleshoot the default settings vs their own settings, so put it somewhere they can see it.
Maybe we could show "My Setting" vs "Default Setting" for each of these settings on the UI or something in the future... can decide UX needs as we go, but the data is there now.
Other
Clean up some hard-coded values we don't need from config